johnfactotum / foliate

Read e-books in style
https://johnfactotum.github.io/foliate/
GNU General Public License v3.0
5.25k stars 254 forks source link

Icons not rendering properly in some parts of the application #1326

Closed daviduzondu closed 1 month ago

daviduzondu commented 1 month ago

Describe the bug Icons for "annotations", "bookmarks" and "catalogs" are not rendered properly

To Reproduce Steps to reproduce the behavior:

  1. Install the snap package.
  2. Open the app.
  3. Find missing icons.

Expected behavior The icons are supposed to be there. This is a small issue that doesn't affect my reading experience, but it is an issue nonetheless.

Screenshots Screenshot from 2024-05-29 14-08-30 Screenshot from 2024-05-29 14-08-07

Version:

johnfactotum commented 1 month ago

The problem is most likely that, for whatever reason, the host icon theme is not exposed in the sandbox. Actually I'm not sure whether Snapd exposes icons themes at all. Unlike Flatpak, it seems that it's necessary to install the Snap version of the icon themes, if you're using a custom theme.

daviduzondu commented 1 month ago

Thanks. The issue has been resolved for me.

For anyone experiencing this on Pop OS with the snap version of foliate, try the following:

Run:

sudo apt install pop-gtk-theme pop-icon-theme

Then install the pop-themes snap package:

sudo snap install pop-themes

Lastly, connect the themes to all apps which have available plugs to gtk-common-themes:

for i in $(snap connections | grep gtk-common-themes:gtk-3-themes | awk '{print $2}'); do sudo snap connect $i pop-themes:gtk-3-themes; done

for i in $(snap connections | grep gtk-common-themes:gtk-2-themes | awk '{print $2}'); do sudo snap connect $i pop-themes:gtk-2-themes; done

for i in $(snap connections | grep gtk-common-themes:icon-themes | awk '{print $2}'); do sudo snap connect $i pop-themes:icon-themes; done