search

johnfactotum / foliate

Read e-books in style
https://johnfactotum.github.io/foliate/
GNU General Public License v3.0
6.21k stars 289 forks source link

Cannot open context menu on touchscreen #1400

Open julianfairfax opened 1 week ago

julianfairfax commented 1 week ago

As described in the title, tested on the latest Flatpak version.

I tested this on my PineTab2. Neither a single press, double press, or longpress would open the context menu. The touchpad works.

johnfactotum commented 1 week ago

There isn't a context menu. If you are able to select text you should see a menu upon selection (for touchscreen selection, see #207).

camelCaseNick commented 1 week ago

If you are able to select text you should see a menu upon selection

That does not happen on touchscreens. Text selection is, while not a great experience, somewhat possible via double and triple tap. But the selection menu does not pop up.

johnfactotum commented 4 days ago

Does the menu pop up if you tap on the selected text?

julianfairfax commented 4 days ago

No, it just selects it

johnfactotum commented 4 days ago

I mean if you select some text with double tap, and then tapping on the selected text again.

If you do this too quickly it would be treated as a triple tap. So you need to wait long enough before tapping the third time, which should deselect the text (which is the normal behavior). But in Foliate, in addition to the text being deselected, it would also open the selection menu if it's not already opened (which is actually a bug).

If that does not happen, I would guess that there might be some GTK bug that prevents the popover from showing.

julianfairfax commented 4 days ago

I mean if you select some text with double tap, and then tapping on the selected text again.

That deselects it.