search

johnfactotum / foliate

Read e-books in style
https://johnfactotum.github.io/foliate/
GNU General Public License v3.0
6.33k stars 289 forks source link

Yellow highlighted text isn't very perceivable in night mode #728

Open demeralde opened 3 years ago

demeralde commented 3 years ago

Describe the bug The yellow highlighted text isn't very perceivable on Ubuntu's night mode (and it'd be the same for other apps, like Flux). Other colours do, including orange.

To Reproduce Steps to reproduce the behavior:

  1. Highlight text in yellow
  2. Activate night mode (using Ubuntu's night mode)
  3. It shouldn't be very perceivable

Expected behavior Yellow highlighted text should be a variant which is perceptible in night mode.

Version:

johnfactotum commented 3 years ago

Currently the default, named colors are directly applied as X11/Web color names. What should be done instead is probably making those configurable in theme settings, as the contrast would be highly dependent on the theme's background color.

demeralde commented 3 years ago

@johnfactotum I think the default colour should be changed anyway, it doesn't stand out much and blends in with the background. I bet there's one which will work in normal light settings, plus all variants of night mode.

The most important thing would be to test it against the most intense night light setting, because this is the most yellow. If it works for that, it should work for the rest, too.