[Feature Request] Dark mode

johnfactotum / quick-lookup

Simple GTK dictionary application powered by Wiktionary

GNU General Public License v3.0

94 stars 8 forks source link

[Feature Request] Dark mode #9

Closed benjezzy closed 2 years ago

benjezzy commented 3 years ago

Currently using the flatpak version but there's no option to toggle a dark mode (which is easier on the eyes).

Could this be implemented? If not, could it align to the gtk theme that is already set?

Thanks!

johnfactotum commented 3 years ago

It should already use the system GTK theme if the corresponding theme extension is installed.

I suppose we can add an option to enable app-specific dark mode. But note that if your system GTK theme isn't available in the Flatpak environment, it will fallback to a version of Adwaita that does not have a dark variant and the dark mode setting would have no effect. In other words, you should install the corresponding Flatpak theme no matter what.

HarryMichal commented 2 years ago

This is handled automatically by libadwaita.

benjezzy commented 2 years ago

Seems like it depends on which version you run.

On the same system:

When using the Flatpak version (currently on v1.2) --> theme is white (despite having corresponding dark theme installed via Flatpak) Error message: Gtk-Message: 23:23:10.582: Failed to load module "xapp-gtk3-module" Gtk-Message: 23:23:10.582: Failed to load module "canberra-gtk-module"
When using the AUR version (currently on v2.0) --> theme is dark

Looks like I'll be sticking with the AUR version for now, happy for this issue to be closed (assuming it'll be solved whenever the Flatpak version gets v2.0)

johnfactotum commented 2 years ago

Right. This is fixed with libadwaita in v2.0. So I guess this can be closed now.

The Flatpak version doesn't have v2.0 because technically, WebKitGTK isn't stable for GTK 4 yet, so it's not in the stable GNOME runtime yet (I think).