search

johnfanv2 / LenovoLegionLinux

Driver and tools for controlling Lenovo Legion laptops in Linux including fan control and power mode.
https://github.com/johnfanv2/LenovoLegionLinux
GNU General Public License v2.0
1.29k stars 49 forks source link

Fix kernel module build fail #200

Closed st0nie closed 2 months ago

st0nie commented 2 months ago

CC @MrDuartePT @johnfanv2

I'm not sure if this affects the functionality of the kernel module or not But it looks like these functions are only called in the same file

MrDuartePT commented 2 months ago

@st0nie it shoudn't, test changing powermodes and fancurve in gui (is what this code is responsible to do) if everthing work alright just merge it

MrDuartePT commented 2 months ago

Well also add the kernel patch build test to the manual action just to see if still failing. The kernel patch seems be working the error seems like a ubuntu thing and old gcc. If still fails I try to build the kernel with clang or disable the kernel build, since is not needed to test the build to create the kernel patch (not ideal but better that having a fail build)