refactor project and paths relationship and extract builders

johnfn / ts2gd

💥 Compile TypeScript to GDScript for Godot

200 stars 14 forks source link

Closed ksjogo closed 2 years ago

ksjogo commented 2 years ago

This change-set is largely doing the following things:

Make the TsGdProject.Paths property not static anymore, but instead bound to the project instance
Pass that project instance to the places needing paths instead of doing an import
Move some path functionality to the Paths class
Facade the library generation functions with a DynamicDefinitionBuilder and a LibraryDefinitionBuilder that take a project as argument (and use that to provide paths to their functions)

TODO:

ksjogo commented 2 years ago

Definition generation is currently broken.

johnfn commented 2 years ago

I really need to add a testing harness around definition generation :)

ksjogo commented 2 years ago

I meant, I broke it in this PR somehow, need to fix. :) But yeah, more automated test won't hurt :D

ksjogo commented 2 years ago

Actually def generation works fine. It was an issue with my local setup. So please have a look. :)

johnfn commented 2 years ago

Is this ready to be reviewed again? :)

ksjogo commented 2 years ago

Yeah, I updated it in regards to the comment above, except the interface.

johnfn commented 2 years ago

Awesome, kinda busy for the next few days but should get to it soon!

ksjogo commented 2 years ago

No worries, I can develop on top of it for the moment.

ksjogo commented 2 years ago

Updated with the minor last things, should be good to go now :D

johnfn commented 2 years ago

Awesome!! Thanks for the PR!