search

johnfn / ts2gd

💥 Compile TypeScript to GDScript for Godot
210 stars 14 forks source link

Use real mockProject for test runs instead of virtual empty project #57

Open ksjogo opened 2 years ago

ksjogo commented 2 years ago

Windows will be fixed with #82 So let's wait for that to go green. But can be reviewed now.

ksjogo commented 2 years ago

All tests run fine now. On my machine total testing changed from ~1.95s to ~2.1s, which for me is acceptable. Can probably optimise some IO for tests, if we would like to (or run in parallel without global).

johnfn commented 2 years ago

This is fantastic. Can't wait to finally test asset generation.

ksjogo commented 2 years ago

This one is reviewable now. Windows tests will be fixed in the windows mr (or i can merge these two, but that would go out of hand).

johnfn commented 2 years ago

This is awesome. Sorry it took me a few days to get to this - somehow I totally missed your message.

It looks like it's failing CI though?

ksjogo commented 2 years ago

Yeah, as the path handling is broken on Windows. (Which wasn't triggered before without the real project). That is fixed in the Windows PR, but that would make this even bigger). If you want green merges, you could review both, then we merge windows fixes into this one and then merge this one.

ksjogo commented 2 years ago

Any thoughts here?

johnfn commented 2 years ago

Sorry for disappearing for a little here - I got super busy. I'll merge this in soon. :)

ksjogo commented 2 years ago

No worries, will need the trifecta with some more changes for a work project end of month and might need to keep further changes bundled to get me there in time. We can try to unwrap after.