check_version and _unused

johnfn / ts2gd

💥 Compile TypeScript to GDScript for Godot

200 stars 14 forks source link

check_version and _unused #58

Open ksjogo opened 2 years ago

ksjogo commented 2 years ago

Both files seem not used/their one calling site commented out. Should they be removed?

johnfn commented 2 years ago

Oh, it's actually very much intended for checkVersionAsync to be used! I must have unintentionally commented it out. The idea is just to show a warning if you're on an old version of ts2gd.

As for _unused, it is indeed... unused. :D It was to remind myself of some TS cases I should consider but it's not necessary any more. We can definitely get rid of that one.