johnfn / ts2gd

💥 Compile TypeScript to GDScript for Godot
200 stars 14 forks source link

fix main awaits #74

Closed ksjogo closed 2 years ago

ksjogo commented 2 years ago

Currently the main process didn't correctly call the await and was silently swallowing errors like the EACCESS ones from the bloodfever ci builds: https://github.com/KronbergerSpiele/bloodfever/runs/4633955575?check_suite_focus=true#step:6:292

Related to #51 (It isn't a fix for that, but now shows the correct error, which I currently think is unrelated)

I did add a lint rule to avoid these issues in the future.

Additionally use the promised version in the source compilation path to streamline error handling.

johnfn commented 2 years ago

Yea yea this looks good. Really just left some trivial nits but I'm willing to merge it whenever you want :)

ksjogo commented 2 years ago

Updated. I also converted some of the compilation to the async version to streamline the behaviour there.

johnfn commented 2 years ago

Thanks!

johnfn commented 2 years ago

Thanks!