johnfraserss / ICS4U

ICS4U Course for John Fraser SS
MIT License
23 stars 32 forks source link

feat: major refactor, add Python, Java, C++ support #25

Closed davidli3100 closed 3 years ago

davidli3100 commented 3 years ago

Refactored searching, sorting, and recursion submodules to sort by languages

TODO

Python:

Java:

C++:

davidli3100 commented 3 years ago

Ready to merge if it looks good to you @mrseidel - I can add searching/sorting for c++ based on whether or not you want to use vectors or just plain C arrays in those.

(C arrays get a little sketchy since you have to start doing sizeof(array)/sizeof(array[0]) to get the length of the array)

mrseidel commented 3 years ago

Ready to merge if it looks good to you @mrseidel - I can add searching/sorting for c++ based on whether or not you want to use vectors or just plain C arrays in those.

(C arrays get a little sketchy since you have to start doing sizeof(array)/sizeof(array[0]) to get the length of the array)

Vectors are easier to work with overall, so go in that direction. I'll review this pull request tomorrow.

davidli3100 commented 3 years ago

Implemented searching/sorting using vectors - I used vector::operator[] instead of vector::at just so it causes minimal confusion - not sure if boundary checking really matters here since it's just some basic algorithms

davidli3100 commented 3 years ago

Refactored folder names to use C++ and C# - I left the file names the same since they match the class names