Print Styles Need Implementation

[johnfrenchxyz]

Many of the things on the print2015.css need to be implemented, including hiding navigation, the .noPrinting class, etc.

Also might be worth including this little bit, which turns off Foundation's inclination to print link hrefs:

<style>@media print{a[href]:after{content:none}}</style>

Here's a page that often gets printed

[bwhet]

How is this one a bug, but the other issues are enhancements? Do we get to create our own label names, or are they pre-defined?

[johnfrenchxyz]

@bwhet Sorry I just saw this. Yes, we can create our own label names, which we should talk about from a project management perspective. I marked this one as a bug because the print styles that were standard functionality on the old site are now not working because I haven't added them. So, it's a weird mix of feature request, enhancement, and bug.

[johnfrenchxyz]

Just added print styles to the CSS. So far, most obtrusive page elements are hidden.  Need to test on an app by app basis to see how tables behave, etc, before closing this issue.

[johnfrenchxyz]

Okay, so the print styles look great on my GitHub page, but applied to dev, the content seems to be super small and in the center. This is what I'm currently investigating:

[johnfrenchxyz]

Hey, @bwhet - I am relatively happy with the results, in the sense that it strips out everything... but printing adds file information and page numbers, and the tables in particular overlap them (which can look messy). Is that something that you've just dealt with in the past? I am looking for a way around it, but no such luck as of yet. Everything else is working as intended though.

[bwhet]

Did this <style>@media print{a[href]:after{content:none}}</style> not work for stripping out the hrefs?

[johnfrenchxyz]

Trying now!

[johnfrenchxyz]

That definitely helped a lot. If you take a look at the print styles of this page you can see there is still an overlap, but it is significantly cleaner than it was.

[bwhet]

yeah, that's a lot better.

has the .noPrinting class been implemented yet?

---

Benjamin Whetstone | IT Senior Manager, Web Team Office of Information Technology College of Agricultural and Environmental Sciences University of Georgia 706) 542 -9018

---

From: John French notifications@github.com Sent: Thursday, December 22, 2016 12:57:15 PM To: johnfrenchxyz/Intranet Cc: Benjamin Whetstone; Mention Subject: Re: [johnfrenchxyz/Intranet] Print Styles Need Implementation (#33)

That definitely helped a lot. If you take a look at the print styles of this pagehttp://devapps.caes.uga.edu/extensionexpertise/index.cfm you can see there is still an overlap, but it is significantly cleaner than it was.

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/johnfrenchxyz/Intranet/issues/33#issuecomment-268854626, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AXeP5DMZbLOW0dZnbXIdC89WY2YnPpMXks5rKrn7gaJpZM4LPdvw.

[johnfrenchxyz]

No, what does that need to do? display:none; on print? Would it just be: .noPrinting { @media print { display: none; } }

[bwhet]

Yeah, pretty much. Check out print2015.css for more stuff that might be useful.

---

Benjamin Whetstone | IT Senior Manager, Web Team Office of Information Technology College of Agricultural and Environmental Sciences University of Georgia 706) 542 -9018

---

From: John French notifications@github.com Sent: Thursday, December 22, 2016 1:04:34 PM To: johnfrenchxyz/Intranet Cc: Benjamin Whetstone; Mention Subject: Re: [johnfrenchxyz/Intranet] Print Styles Need Implementation (#33)

No, what does that need to do? display:none; on print? Would it just be: .noPrinting { @media print { display: none; } }

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/johnfrenchxyz/Intranet/issues/33#issuecomment-268856142, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AXeP5GrBB0kSGv5L9MP4-fkMkBi-8izQks5rKruygaJpZM4LPdvw.

[johnfrenchxyz]

That class has been added. I'd love to get together as a group and start doing some significant testing for print styles.

[bwhet]

Want to set a meeting on the calendar?

---

Benjamin Whetstone | IT Senior Manager, Web Team Office of Information Technology College of Agricultural and Environmental Sciences University of Georgia 706) 542 -9018

---

From: John French notifications@github.com Sent: Tuesday, January 3, 2017 10:17:15 AM To: johnfrenchxyz/Intranet Cc: Benjamin Whetstone; Mention Subject: Re: [johnfrenchxyz/Intranet] Print Styles Need Implementation (#33)

That class has been added. I'd love to get together as a group and start doing some significant testing for print styles.

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/johnfrenchxyz/Intranet/issues/33#issuecomment-270136851, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AXeP5L3yNwY4afMk0R8fIpApm17NB1fVks5rOmZ7gaJpZM4LPdvw.

[ghost]

FINALLY THds is dune