search

johnfrenchxyz / Intranet

The Phase I redesign of the CAES Apps/Intranet ecosystem.
0 stars 0 forks source link

Need to actually be able to remove navigation #49

Closed bwhet closed 7 years ago

bwhet commented 7 years ago

Currently contentWidth="full" and LocalNavigation = 'none' means that the navigation gets put at the top of the page... But I don't see any way to have a full width page with no navigation at all.

bwhet commented 7 years ago

Also, whatever LocalNavigation is set to overrides anything entered in contentWidth. How about:

Question #1: What happens if ContentWidth is Full but Navigation is Basic? Probably just treat that as an error state and don't snow the nav at all. Or, if foundation columns don't prevent it, nav could be displayed on left. Either way.

Question #2: What happens if ContentWidth is Basic but Navigation is None? This would cause ContentWidth to act as if it were "Full" right? I reckon that's cool.

ghost commented 7 years ago

I mean, essentially that would result in three possible configurations, all really just depending on LocalNavigation.

If LocalNav is basic, ContentWidth is basic. If Localnav is collapsed or none, ContentWidth is full.

Right?

If that's the case, couldn't we do away with one of the variables and just rely on the other?

bwhet commented 7 years ago

Yes.

I can't think of a need for both in the future, so I'm fine with that.

Benjamin Whetstone | IT Senior Manager, Web Team Office of Information Technology College of Agricultural and Environmental Sciences University of Georgia 706) 542 -9018

From: Gabriel Benson notifications@github.com Sent: Wednesday, December 21, 2016 2:55:07 PM To: johnfrenchxyz/Intranet Cc: Benjamin Whetstone; Author Subject: Re: [johnfrenchxyz/Intranet] Need to actually be able to remove navigation (#49)

I mean, essentially that would result in three possible configurations, all really just depending on LocalNavigation.

If LocalNav is basic, ContentWidth is basic. If Localnav is collapsed or none, ContentWidth is full.

Right?

If that's the case, couldn't we do away with one of the variables and just rely on the other?

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/johnfrenchxyz/Intranet/issues/49#issuecomment-268623037, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AXeP5DqAQOgTYZSXvi6ZL9uYc5heF6Y2ks5rKYQbgaJpZM4LR34p.

bwhet commented 7 years ago

Woah.

I think I just replied to the email and my reply got added as a comment.

My dreams are coming true.

Benjamin Whetstone | IT Senior Manager, Web Team Office of Information Technology College of Agricultural and Environmental Sciences University of Georgia 706) 542 -9018

From: Gabriel Benson notifications@github.com Sent: Wednesday, December 21, 2016 2:55:07 PM To: johnfrenchxyz/Intranet Cc: Benjamin Whetstone; Author Subject: Re: [johnfrenchxyz/Intranet] Need to actually be able to remove navigation (#49)

I mean, essentially that would result in three possible configurations, all really just depending on LocalNavigation.

If LocalNav is basic, ContentWidth is basic. If Localnav is collapsed or none, ContentWidth is full.

Right?

If that's the case, couldn't we do away with one of the variables and just rely on the other?

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/johnfrenchxyz/Intranet/issues/49#issuecomment-268623037, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AXeP5DqAQOgTYZSXvi6ZL9uYc5heF6Y2ks5rKYQbgaJpZM4LR34p.

johnfrenchxyz commented 7 years ago

@bwhet it even has an email icon next to your name to indicate that the response came from mail.

I am a big dummy, too.

bwhet commented 7 years ago

It's weird, though, because remember I specifically asked whether it would support comments via email -- and it didn't look like it did at first.

Awesome.

Sorry to junk up the thread.

Benjamin Whetstone | IT Senior Manager, Web Team Office of Information Technology College of Agricultural and Environmental Sciences University of Georgia 706) 542 -9018

From: John French notifications@github.com Sent: Wednesday, December 21, 2016 3:03:45 PM To: johnfrenchxyz/Intranet Cc: Benjamin Whetstone; Mention Subject: Re: [johnfrenchxyz/Intranet] Need to actually be able to remove navigation (#49)

@bwhethttps://github.com/bwhet it even has an email icon next to your name to indicate that the response came from mail.

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/johnfrenchxyz/Intranet/issues/49#issuecomment-268625007, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AXeP5BddeDplujyRLVCN5OSCMoXVDedWks5rKYYhgaJpZM4LR34p.

ghost commented 7 years ago

This is done!

The ContentWidth variable isn't used anywhere in the new template. LocalNavigation can be "basic", "collapsed", or "none". Basic collapses on mobile.