Show the Post ID for the Post Meta results

cliffordp commented 8 months ago

First time using the plugin, tyvm for it.

1) Please provide the Post information (Post ID with edit/view links) even for the Post Meta results:

P.S. 2) Shouldn't the Row# be without a comma, in case I want to copy it? 3) Please make it more obvious that clicking on the result will perform the replacement, not just if I hover over it for a while to view the <title>. It'd be nice if there was a Read Only view/toggle so I don't do accidental clicks.

johngodley commented 8 months ago

Clicking on the result doesn't immediately perform the replacement.

cliffordp commented 8 months ago

meaning it does eventually?

johngodley commented 8 months ago

Yes. Have you pressed it?

cliffordp commented 8 months ago

No, just was looking for Replace All. FYI: it was not obvious it was only going to replace the page size (25 quantity) and not actually all

johngodley commented 8 months ago

It does replace all and not just the page size. Are we still talking about the same thing?

cliffordp commented 8 months ago

OK, I tried the single click on orange and that's nice! maybe the should change from "Click to replace match" to "Click to replace manually"</p> <p>I found it odd, though, that clicking on it does not prompt me with the global replacement (my shortcode in this example) but instead reverts it back to the original:</p> <img width="479" alt="image" src="https://github.com/johngodley/search-regex/assets/1812179/b5713c5a-b80e-472c-82dd-130fbbef2cb0"> <p>And when I tried replacing it solo (orange) it gave an error:</p> <pre><code>Plugin: 3.0.8 WordPress: 6.4.2 (single) PHP: 7.4.33 256M 300s Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36 JavaScript: /wp-content/plugins/search-regex/search-regex.js REST API: /wp-json/ Query: ?page=search-regex.php&preset=6599900cf12d8 Error: No matching row (rest_invalid_param) Raw: {"code":"rest_invalid_param","message":"No matching row","data":{"status":400}}</code></pre> <p>So I refreshed the page, performed the same search, then used Replace All and that worked.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/johngodley"><img src="https://avatars.githubusercontent.com/u/1277682?v=4" />johngodley</a> commented <strong> 8 months ago</strong> </div> <div class="markdown-body"> <p>If you want to replace globally then you use the 'replace all' button. Details about using the plugin can be found here:</p> <p><a href="https://searchregex.com/">https://searchregex.com/</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/cliffordp"><img src="https://avatars.githubusercontent.com/u/1812179?v=4" />cliffordp</a> commented <strong> 8 months ago</strong> </div> <div class="markdown-body"> <p>Am I understanding correctly that you don't want me to continue reporting bugs and UX improvements?</p> <p>FYI: here's the Replace All doing <em>not all</em> but also <em>not just 25</em> <img src="https://github.com/johngodley/search-regex/assets/1812179/e1985406-2ad2-4c57-9762-64d3c47fc5ce" alt="2024-01-06 SearchRegex Replace All not quite" /></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/johngodley"><img src="https://avatars.githubusercontent.com/u/1277682?v=4" />johngodley</a> commented <strong> 8 months ago</strong> </div> <div class="markdown-body"> <blockquote> <p>Am I understanding correctly that you don't want me to continue reporting bugs and UX improvements?</p> </blockquote> <p>I don't believe I've said that.</p> <p>You have reported things before trying to use them, and it is hard to know what you are currently referring to.</p> <p>I am struggling to make out what you are showing in the gif.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/cliffordp"><img src="https://avatars.githubusercontent.com/u/1812179?v=4" />cliffordp</a> commented <strong> 8 months ago</strong> </div> <div class="markdown-body"> <p>OK, thanks for clarifying. In the gif it shows clicking Replace All when the pagination is 25. It shows 25 rows then it all of a sudden says 152 rows, even though the initial result count was 191 rows. Upon completing the first Replace All, there are 39 rows still found upon performing the same search.</p> <p>For clicking the orange, why wouldn't it pre-fill my replacement value instead?</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

johngodley / search-regex

Show the Post ID for the Post Meta results #175