search

johngodley / search-regex

Search Regex adds a powerful set of search and replace functions to WordPress that go beyond the standard searching capabilities, with full regex support.
https://searchregex.com
GNU General Public License v3.0
32 stars 9 forks source link

I can't activate in PHP 8 #79

Closed t-hamano closed 3 years ago

t-hamano commented 3 years ago

Summary

'Match' is a reserved keyword in PHP 8, so I got a fatal error when I activate the plugin.

Actual Behavior

I got error like this:

Parse error: syntax error, unexpected token "::", expecting "(" in /var/www/html/wp-content/plugins/search-regex/models/search.php on line 322

The reason for the error is that 'Match' is used in the class name.

Steps to reproduce

Change the class name is needed, but 'Match' is the basic name of this plugin. So I don't know of any other reasonable name. Is there a better name?

johngodley commented 3 years ago

This will be fixed in the next version of the plugin.

t-hamano commented 3 years ago

Thanks for the reply. I am looking forward to the next update.