johngraciliano / simplewhite

A minimal theme for Mozilla Firefox.
https://addons.mozilla.org/addon/simplewhitex/
Mozilla Public License 2.0
44 stars 4 forks source link

The theme needs corrections to support RTL locales. #10

Open johngraciliano opened 8 years ago

johngraciliano commented 8 years ago

Some corrections are needed to properly support languages that are written right to left, e.g., arabic. In particular the back and forward button's icons need to be swapped. Also, I made changes to the new tab page that only look correctly on ltr locales. However the changes I did to the about:preferences page were done with consideration to both ltr and rtl locales. With some luck, the support for rtl locales only needs the corrections to the back and forward buttons and to the new tab page. I however need to check other things, for instance, any changes I may have done to the developer tools support and check for any "go" arrows.

johngraciliano commented 8 years ago

The new tab page code is now correct. Not it has compatibility with all locales and an enhanced design.

johngraciliano commented 8 years ago

The browser will now present the back and forward buttons properly in rlt locales. The sections that are laid left to right in rtl locales are result of inadequate default settings within Firefox. Any incorrect layouts in rtl locales with Simple White X are also incorrect with the default theme.

johngraciliano commented 8 years ago

Minor problems regarding rtl compatibility for the search bar and search suggestion table have been solved for the new tab page with this theme.