search

johngraciliano / simplewhite

A minimal theme for Mozilla Firefox.
https://addons.mozilla.org/addon/simplewhitex/
Mozilla Public License 2.0
44 stars 4 forks source link

Invisible background on fullscreen video warning #20

Closed ghost closed 8 years ago

ghost commented 8 years ago

Firefox's new(ish) notice about having turned on fullscreen when playing a video is invisible and looks rather bad, see the screenshots below (Simple White first, default theme second).

Simple White X

Default

johngraciliano commented 8 years ago

Thank you for that information, I have not paid attention to that, I am not sure I want a background. However, if there is text it should be readable, so it may need a background. If there is a red frame I certainly do not want that.

ghost commented 8 years ago

The red frame is something I added to highlight the barely visible text. This is how it looks on a light background:

fullscreen

johngraciliano commented 8 years ago

I have seen that and I am not sure I would change it. I would rather show nothing at all, yet a theme should not do that. If I change anything, it may be adding some shadow or light outline to help the text be more visible. But I still need to look at it more carefully.

Lootyhoof commented 8 years ago

It would be advisable to add some sort of semi-transparent background-color. Perhaps rgba(255,255,255,.3)?

johngraciliano commented 8 years ago

Sorry to all, I have been busy with #16 and #19. I have noticed this notification is a bit changed from what it was. It shall be re-designed for a future release, not the next one.

johngraciliano commented 8 years ago

All things considered a semi-transparent background will be part of the solution, as seen in the sample: fullscreen The change is not merged yet.

johngraciliano commented 8 years ago

After a small redesign the sample shown before, the solution is out in the release v2.2b18.x1.11.