johngraciliano / simplewhite

A minimal theme for Mozilla Firefox.
https://addons.mozilla.org/addon/simplewhitex/
Mozilla Public License 2.0
44 stars 4 forks source link

Wonky looking notifications with firefox 46 #23

Closed bwat47 closed 8 years ago

bwat47 commented 8 years ago

With the simple white x theme, web notifications don't look very good (there's an ugly dropdown menu in the middle, odd placement of the X button, corners don't look rounded properly and it shows a space for an image on the left even when the notification doesn't display an image).

I've attached a screenshot of a notification with the simple white x theme and a notification with the default theme for comparison.

Default: default-notification

Simple White X simple-white-notification

This is with firefox 46 beta 2

johngraciliano commented 8 years ago

Thank you for your report. Can you list the steps of how to reproduce the problem?

bwat47 commented 8 years ago

I used this test page for the screenshots: https://jsfiddle.net/yoshi6jp/Umc9A/

  1. Click on Request permission
  2. When firefox prompts, allow firefox to show notifications
  3. Click the Show button to trigger a web notification
johngraciliano commented 8 years ago

I am working on it. Thank you again, now also for providing me with an easy tool for diagnosis.

johngraciliano commented 8 years ago

The alerts box (chrome://global/content/alerts/alert.xul) layout was changed in Firefox 44, so the solution is past due. Another important change was introduced with the current Firefox 45: Now the box has a shadow because the window where it is rendered can have a transparent background.* I verified this in Windows 8. I am working under the assumption this is also true for other platforms. I should have a new version fixing and a few minor issues in a couple of days.


*The box position is different for because it is in a padded window.

johngraciliano commented 8 years ago

The corrected theme is release v2.2b18.x1.13.

bwat47 commented 8 years ago

awesome, thanks :)