search

johngraciliano / simplewhite

A minimal theme for Mozilla Firefox.
https://addons.mozilla.org/addon/simplewhitex/
Mozilla Public License 2.0
44 stars 4 forks source link

A tab bug happens when Firefox stars on one tab #29

Closed Devlinyang closed 8 years ago

Devlinyang commented 8 years ago

@johngraciliano ,hello! A tab bug happens when Firefox stars on one tab,please see followed picture~ baidushurufa_2016-5-12_15-30-16

Devlinyang commented 8 years ago

the version is 2.2b18.x1.17 on firefox 46.0.1

johngraciliano commented 8 years ago

What OS? I only have Windows 8 so I may need your assistance troubleshooting. I see the tab (and the open a new tab button) show no border in your image. Sometimes I see the borders do not who correctly after I switch to a light theme. Does your problem go away if you hove on the tab? Are you talking about something else?

Devlinyang commented 8 years ago

My OS is Win7 64bit, yes ,as you said the tab have no borders initial，but when I hove/move or add a tab it return to normal. I really want assist you as I can~ I know little about code... initial: 1 after add a tab: 2

johngraciliano commented 8 years ago

Thank you for your offer. I may need your help but not yet. I was actually able to confirm this issue in my system using Firefox 45 and Firefox 46. However, it is not present with Firefox 44.0.2 nor Firefox 47 beta 4 (I have not tried other versions yet). Since I am able to reproduce it locally, I will try to solve it without any more help for now. Your help just pointing out the issue is much appreciated. Please keep attention to the issue because I may still need help.

johngraciliano commented 8 years ago

Good and bad news. The good news is that I was able to find a solution that works in my system. Recently, I have found problems while working on the implementation of the Firebug theme for the Developer Tools, I made some quick analogies between those and this problem which lead me to a work around what I think causes this issue. The bad news is that I want to complete more of the work regarding the Developer Tools before I publish the next release. Yet I may not complete that part before making a release with a solution to this issue because it is relevant since Firefox 45 (it may not be so important in Firefox 47!). I may put the change that fixes this issue in this repository within a day before any release at AMO to have it closed. Again, thank you @Devlinyang.

johngraciliano commented 8 years ago

@Devlinyang: Please verify the latest release fixes this issue. Close the issue after you verify is fixed. It may take a few more days before a release with the fix is published at AMO.

Devlinyang commented 8 years ago

Thank U very much! I just online. I will check the result and close the issue~

Devlinyang commented 8 years ago

@johngraciliano ,OK, it's done~very nice u~