search

johngraciliano / simplewhite

A minimal theme for Mozilla Firefox.
https://addons.mozilla.org/addon/simplewhitex/
Mozilla Public License 2.0
44 stars 4 forks source link

The about:preferences/options page does not follow the motif of this theme. #3

Closed johngraciliano closed 8 years ago

johngraciliano commented 8 years ago

The options page is filled with lively colors! It's cheery but I do not think it is appropriate for this theme. I am redecorating the options page to look like the addons page and most of the blue will turn into gray. As soon as I clean the code, I will upload a version with the changes as a branch. I have yet to produce icons with the new size. I am temporarily using inverted (negative) resized images of current icons. A sample of the new (retro) look is at the bottom. Note: I want to change the Advanced options icon to a five point star. I think that change is long overdue after the change to the wizard's hat with a five point star in the default/classic theme.
Please comment!

options

lychichem commented 8 years ago

If you use five point star, do you mind some users thinking it related to bookmark setting?

johngraciliano commented 8 years ago

@lychichem: I see they use stars for bookmarks in the default theme now (I use the default theme only for reference and very rarely). I think of a star as how a general can be distinguished from other officials. Stars are used to signify high rank (e.g., they are use for rating). I think using a star for stating "Advanced" makes better sense than saying "Bookmark" yet I can think of that other connection. It can certainly create a little confusion initially for those accustomed to the default theme. But I think is better to have a star than to reuse the symbol for options in general. I sincerely hope people will see it is the star in the wizards hat! I already made new hand-coded svg icons and I am about to merge all changes to the main branch. (I later found the location for png icons with the needed size). I chose not to get rid of all the blue. The links will remain blue (at least for now) because I am a bit concerned how oblique characters with light underline works with characters from Asian languages (I have no idea). That plus the facts: (1) the css for this is used in a few other pages and (2) blue is use for links elsewhere in the theme.

johngraciliano commented 8 years ago

The changes are now in pre-release form.

johngraciliano commented 8 years ago

As @lychichem voiced a concern about the possible confusion a star may give as the Advance symbol I pondered deeply for an alternative. Since the wizard's hat is too complicated and may look silly if simplified, I considered a top hat (like a magician's hat) but that would also be silly. I considered several ideas, one of which was a kite. As reconsidering the wheel symbol used in the options and thinking what would the most advanced version of that would be, I found the radioactive danger symbol as a suitable alternative (I was looking for a symbol for atomic energy). So the current alternatives for the Advanced options are the star (current) and the radioactive danger (proposed). Please anybody give your thoughts.

star

radio

lychichem commented 8 years ago

New icon looks OK. Let's use it.

johngraciliano commented 8 years ago

_Two Problems Pending:_

  1. _IMPORTANT!_ I am afraid my changes to the master branch did not consider the Darwin OS and the options page form the release candidate for 2.2b18.x1.03 will look bad in Apple computers. That is because one of the two css files changed, common.css, has an separate version for the Darwin OS but not the other one, which would mean the icons may change while the style remain the same, and that is a problem because the new (retro) icons are black (and have a different size). I have no means for testing, so help for testing on those systems is needed. However, I will try to make the relevant changes to the code for another candidate.
  2. I understand the radioactive icon is OK. I yet need to make* a slightly smaller version for the old preferences (pop-up) window. It has been neglected may be missing some settings, but it still works and I prefer it!

*Writing this code reminds me need to review trigonometry, yet I did not need to use trigonometric functions to code the radioactive icon as I did with the star because 60° angles are easy :)

johngraciliano commented 8 years ago

I made corrections in the code to solve any pending problems in this issue some days ago. I am still awaiting for confirmation of fix (or otherwise) because I do not have access to an Apple computer to test the correction.

johngraciliano commented 8 years ago

Due to the lack of feedback, the assumption is this issue is solved for all Firefox implementations. Therefore I am closing it.