search

johngraciliano / simplewhite

A minimal theme for Mozilla Firefox.
https://addons.mozilla.org/addon/simplewhitex/
Mozilla Public License 2.0
44 stars 4 forks source link

[OS X] Title bars appearance is strange, when showing Titlebar #33

Open suishouen opened 7 years ago

suishouen commented 7 years ago

While I'm testing a test version: v2.2b18.x1.23+S with a fresh profile, I noticed this issue. And this issue occurs throgh Firefox 48 to 51.

Steps to reproduce: Show Titlebar (Click "Title Bar" button in customize window ).

Screenshots are coming... Showing Titlebar and Normal browsing mode show titlebar1

Showing Titlebar and Always private browsing mode show titlebar2

This issue doesn't exist when hiding Titlebar

Hiding Titlebar and Normal browsing mode hide titlebar1

Hiding Titlebar and Always private browsing mode hide titlebar2

johngraciliano commented 7 years ago

From your image it appears the title bar is incorrect for private browsing windows. You may correct me if I am wrong because I am not sure of how it should look. It also appears to me that the private browsing window badge is always missing. Please let me know if this is different in earlier versions of Firefox. Note that I have done very few changes for the OS-X platform because I cannot test for it, so I only work for that if anyone sets an issue and someone is able to help (at least testing) for that issue. This theme is a fork of a theme done for Firefox 39 hence any particular changes in Firefox for OS-X may be missing. All that stated I will add: I will see what I can do. I am queued to merge with newer code that was done in default for OS-X. That may help.

suishouen commented 7 years ago

Just for reference: attaching the screenshot with my private SimpleWhite on Firefox 51.0a1. This works well only on always private mode, though.

Always Private Browsing Mode:

screenshot1

suishouen commented 7 years ago

@johngraciliano:

I'm a beginner of css coding, so I can't explain well. Instead I'm attaching screenshots of default theme for your information and use.

Showing Titlebar and Normal browsing mode show-normal

Showing Titlebar and Always private browsing mode show-private

Hiding Titlebar and Normal browsing mode hide-normal

Hiding Titlebar and Always private browsing mode hide-private

Best regards.

suishouen commented 7 years ago

@johngraciliano:

I tried removing [chromemargin] parts (/* Added [chromemargin] --johnGraciliano */) from /whitefox/ostarget/darwin/browser.css.

This is the screenshots of trial. Showing Titlebar and Normal browsing mode screenshot

I hope you find it informative. Best regards.

johngraciliano commented 7 years ago

@suishouen:

Those lines you mentioned were changed in perhaps one of maybe two or three cases I did specific work for OS-X. I worked on that almost guessing what could happen (I still do that often!) to solve an issue in the original Simple White (I think) and was kindly aided by a gentleman with a lot of patience. I am very grateful for that, and you patience too, as is possibly one of the hardest thing on most people.

I noticed this may some of this may have changed recently because in some of the images you provide for issue #32 (images using inherit, 1.06em, and 13px) the top where the page title is shown looks different. Anyway, if it is possible for you at all, compare with current Firefox 48 (and if possible with Firefox 39). I am glad you test with Nightly as it is the only way to stay current.

suishouen commented 7 years ago

Sorry for posting to the wrong place. Delete...