search

johngraciliano / simplewhite

A minimal theme for Mozilla Firefox.
https://addons.mozilla.org/addon/simplewhitex/
Mozilla Public License 2.0
44 stars 4 forks source link

Improve Developer Tools Dark Theme #34

Open johngraciliano opened 7 years ago

johngraciliano commented 7 years ago

Please help! Review the last experimental release. I need images of the options tab in OS X. I also need images of pop up and pull down menus. I also need images with the experimental and non-experimental releases. I especially need images from Firefox 45 ESR or older Firefox because the release is versions starting from Firefox 37.

Images from any OS are welcome, especially if they show any problem.

Lootyhoof commented 7 years ago

I've had a look at this with the linked release, Firefox 45 ESR on OS X 10.11 (El Capitan). See below, the options tab (in fullscreen mode) and the devtools themselves - not sure what you refer to with regards to popup and pulldown menus though.

Options Devtools

Of note it appears that the dropdown is shaded incorrectly, with two checkmarks (one native, one provided in icon form).

johngraciliano commented 7 years ago

Thank you so much!!!! It is comforting to find someone that cares 👍 I yet do not know how it looked without my changes. That would give me an idea of the native style and what should I aim to achieve. I think the check marks look ok. However the selection points may still need work. P.S. I was talking about the pull down lists as I showed in my image, i.e., for the default color unit. The image you provided gives a good indication of problems with the pop-up menus. Thank you.

Lootyhoof commented 7 years ago

Apologies for the day, in addition to the initial confusion. Here are more screenshots, of both the default devtools (in light and dark), as well as Simple White X's devtools options page (in light and dark).

1 2 3 4 5 6 7 8

I notice that the dark dropdown doesn't appear to be legible, since it attempts to use the OS X menu style but the dark-theme menu colours.

Glad to help! 👍

johngraciliano commented 7 years ago

Thank you again, sorry for being a bit slow... all your feedback is tremendously useful. I will try my best to upgrade accordingly...

johngraciliano commented 7 years ago

Please try out v2.2b18.x2.0+S3

Lootyhoof commented 7 years ago

Using that version, the light theme works as-expected. The dark theme, however, does not. The radio buttons do not appear (but are functional), the pulldown list is not legible, and while the dropdown looks as expected when highlighted, it is illegible when not highlighted. Please see below.

1 2 3 4

Hope this helps!

johngraciliano commented 7 years ago

I yet need to address the radio buttons.