search

johnholbrook / streamdeck-pihole

Streamdeck plugin for monitoring & controlling Pi-hole
https://apps.elgato.com/plugins/us.johnholbrook.pihole
32 stars 5 forks source link

Pi-Hole API changes breaks plugin api calls #14

Closed marcandrelevesque closed 1 year ago

marcandrelevesque commented 1 year ago

Pi-hole Pi-hole v5.14.2 FTL v5.20 Web Interface v5.18 made changes to their API.

ref: https://github.com/pi-hole/AdminLTE/issues/2326 https://pi-hole.net/blog/2022/11/17/upcoming-changes-authentication-for-more-api-endpoints-required/#page-content

You need to update the plugin to make it works again with the latest version.

billg118 commented 1 year ago

I just got a stream deck yesterday and couldn't figure out why it wouldn't work.

I looked in the code and it looks like its using the correct auth method so IDK If thats the issue or not.

Either way it sucks I cant get this to work.

marcandrelevesque commented 1 year ago

endpoint authentication is not global anymore, John needs to modify this and hopefully can figure it out because this is beyond my level of programming/config skills.

billg118 commented 1 year ago

I tinkered a bit and fixed it. I put in a pull request. If you want to fix it now just copy the change locally to your plugin.

https://github.com/johnholbrook/streamdeck-pihole/pull/15

johnholbrook commented 1 year ago

Hey, thanks everyone for letting me know about this.

I've accepted @billg118's PR and released v1.1.1 of the plugin which should fix this issue. The new version is available now on the releases page and I've submitted it to the stream deck store.

johnholbrook commented 1 year ago

On second thought, going to leave this issue open until 1.1.1 is available in the store.

blacktwin commented 1 year ago

Just installed v1.1.1 via release page. Fixed my connection issue! Thanks!

johnholbrook commented 1 year ago

1.1.1 is now available in the store.