search

johnholbrook / streamdeck-pihole

Streamdeck plugin for monitoring & controlling Pi-hole
https://apps.elgato.com/plugins/us.johnholbrook.pihole
32 stars 5 forks source link

Allow for https protocoll #9

Closed felixmw closed 1 year ago

felixmw commented 2 years ago

My pihole is running behind a reverse proxy and ssl encryption is applied. Since the 'http' protocol ist hard coded in your scripts I am not able to use your stream deck plugin. It would be great if one could define the protocol either as part of the address or as a separate variable.

Thanks a lot, best, Felix

AquaRelliux commented 1 year ago

Your steamdeck is on the same network as your pihole? You should use split-dns to avoid NAT problems also you should go directly to your pihole via http on your internal network. This will be better security wise and performance wise

digas commented 1 year ago

What do you have to do with and how our network is configured ? This is not the question or the request of the issue . The question / request of the issue is can you change it to be able to use https request or not ? simple . Imagine i have different networks all in the my same network , imagine i'm using pihole on a docker and i actually use VM's this is not the point and i believe it's no own will come here to put question about a pihole not working .. The question is can you change from hardcoding allow the client to choose which protocol he wants to make the request over http or https ? thank you

johnholbrook commented 1 year ago

This feature was added in version 1.2.0, which is now available from the releases page or from the stream deck store.