search

johnhw / pfilter

Basic Python particle filter
MIT License
172 stars 25 forks source link

Weight_fn parameters #7

Closed BoltonBailey closed 5 years ago

BoltonBailey commented 5 years ago

In the documentation in pfilter.py line 165, it says that weight_fn should take parameters "real" and "hypothesized" in that order. But when the function is called in line 240, the "self.hypotheses" attribute is the first argument. Shouldn't the self.hypotheses attribute naturally be called as the hypothesized argument?

johnhw commented 5 years ago

Ah, yes. I have adjusted the documentation to indicate the correct order (hypothesised, real).