search

johnjones4 / Standard-Notes-Clipper

A browser add-on (Firefox and Chrome) that allows you to clip web pages to your Standard Notes account.
MIT License
124 stars 13 forks source link

Inline images #20

Open dannysummerlin opened 4 years ago

dannysummerlin commented 4 years ago

I've added an option to convert img URL references into data URIs, so that if webpages go offline you can still have a copy of the images. There is probably a lot that could be improved on, but I thought this would be a good start.

johnjones4 commented 4 years ago

This is great! Thank you! I will dig in on a deeper review after the holidays. Would you mind addressing the lint issues shown on: https://travis-ci.org/johnjones4/Standard-Notes-Clipper/builds/628439009?utm_source=github_status&utm_medium=notification

dannysummerlin commented 4 years ago

I'm on it!

johnjones4 commented 4 years ago

@dannysummerlin looking good! I just made two comments for you. If you can address those, I will be good to merge this!

johnjones4 commented 4 years ago

Hey @dannysummerlin just pinging you on this. Do you think you can address my comments this week?

dannysummerlin commented 4 years ago

Hey John, I've got a big project this week/month, so I can't swear when I'll have a chance to take a crack at it, sorry!

---- On Tue, 07 Jan 2020 18:23:41 -0500 John E Jones IV notifications@github.com wrote ----

Hey https://github.com/dannysummerlin just pinging you on this. Do you think you can address my comments this week?

— You are receiving this because you were mentioned. Reply to this email directly, https://github.com/johnjones4/Standard-Notes-Clipper/pull/20?email_source=notifications&email_token=AFFRHZDIIANPDI3LAZ4TBZDQ4UFH3A5CNFSM4J6M64A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIKURJI#issuecomment-571820197, or https://github.com/notifications/unsubscribe-auth/AFFRHZHTS7SX4U2T2X2DZLTQ4UFH3ANCNFSM4J6M64AQ.

johnjones4 commented 4 years ago

Just following up on this!

bscott commented 4 years ago

Any update with this?

dannysummerlin commented 4 years ago

Hey y'all, I apologize, for several reasons I've actually switched over to Notion as my note-taker and haven't even fired up Standard Notes in a long time. At this point if any of this code is useful, obviously feel free to use it, but I won't be doing any further work in the Standard Notes world.

bscott commented 4 years ago

@dannysummerlin Thanks for the update, @johnjones4 Are you still active on the project?

johnjones4 commented 4 years ago

@bscott yes still active! Just haven't seen any feature requests or bugs come through lately. I'd love some help with this PR if you are willing to help out.