johnjones4 / Standard-Notes-Clipper

A browser add-on (Firefox and Chrome) that allows you to clip web pages to your Standard Notes account.
MIT License
124 stars 13 forks source link

Can't login #28

Open guyhajaj opened 3 years ago

guyhajaj commented 3 years ago

Just installed the Chrome version. This page opened. I just used the same Server URL, email and password to successfully log in to the desktop app, but here I get this error:

Cannot read property 'length' of null

Thanks for this much-needed extension! Hoping to get it working here too.

sequent5 commented 3 years ago

same problem with my login under chrome or chronium

randy9999 commented 3 years ago

I have been getting the same problem. While trying to log into Standardnotes using the notes-clipper, I keep getting a 'output is null' message. Yet I can log in to Standardnotes itself without any problems...

johnjones4 commented 3 years ago

Hi all - I do not have a private SN server to test this against. Are you able to pull up the dev console for the extension when you try to log in? Are there any additional errors in the log or network tab?

randy9999 commented 3 years ago

Hi,

I don't know what you mean by dev console. The only thing I see is this... [image: Screen Shot 2020-12-01 at 1.31.59 PM.png] I do not see any other messages.

Also, I am logged into the standardnotes website with the same email and password. Without having any problems logging in.

later Randy

On Tue, Dec 1, 2020 at 12:39 PM John E Jones IV notifications@github.com wrote:

Hi all - I do not have a private SN server to test this against. Are you able to pull up the dev console for the extension when you try to log in? Are there any additional errors in the log or network tab?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/johnjones4/Standard-Notes-Clipper/issues/28#issuecomment-736742141, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ2HQIPL4IOKH33VEV2PGPTSSUZ5JANCNFSM4TZG2ZQA .

sequent5 commented 3 years ago

here it is: settings.js:1529 TypeError: Cannot read property 'length' of null at SFCryptoWeb._callee128$ (chrome-extension://ocbkppilalbegahodpaibdgaodllccon/background/background.js:34284) at tryCatch (chrome-extension://ocbkppilalbegahodpaibdgaodllccon/background/background.js:42247) at Generator.invoke [as _invoke] (chrome-extension://ocbkppilalbegahodpaibdgaodllccon/background/background.js:42473) at Generator.prototype. [as next] (chrome-extension://ocbkppilalbegahodpaibdgaodllccon/background/background.js:42299) at asyncGeneratorStep (chrome-extension://ocbkppilalbegahodpaibdgaodllccon/background/background.js:23836) at _next (chrome-extension://ocbkppilalbegahodpaibdgaodllccon/background/background.js:23838) doLogin$ @ settings.js:1529 tryCatch @ settings.js:604 invoke @ settings.js:830 prototype. @ settings.js:656 tryCatch @ settings.js:604 invoke @ settings.js:694 (anonymous) @ settings.js:706 Promise.then (async) invoke @ settings.js:703 (anonymous) @ settings.js:729 callInvokeWithMethodAndArg @ settings.js:728 enqueue @ settings.js:751 prototype. @ settings.js:656 exports.async @ settings.js:775 doLogin @ settings.js:1478 login @ settings.js:1542 onClick @ settings.js:1568 N @ settings.js:84

Thanks

randy9999 commented 3 years ago

Hi,

I just right now tried to get your Standardnotes addon to work. It does not work. I still am getting the same error message...output is null. I have deleted and reinstalled this numerous times, with the idea that maybe an update would start working? Nothing yet...

later, Randy

On Tue, Dec 1, 2020 at 8:17 PM stjohn notifications@github.com wrote:

here it is: settings.js:1529 TypeError: Cannot read property 'length' of null at SFCryptoWeb._callee128$ (chrome-extension://ocbkppilalbegahodpaibdgaodllccon/background/background.js:34284) at tryCatch (chrome-extension://ocbkppilalbegahodpaibdgaodllccon/background/background.js:42247) at Generator.invoke [as _invoke] (chrome-extension://ocbkppilalbegahodpaibdgaodllccon/background/background.js:42473) at Generator.prototype. [as next] (chrome-extension://ocbkppilalbegahodpaibdgaodllccon/background/background.js:42299) at asyncGeneratorStep (chrome-extension://ocbkppilalbegahodpaibdgaodllccon/background/background.js:23836) at _next (chrome-extension://ocbkppilalbegahodpaibdgaodllccon/background/background.js:23838) doLogin$ @ settings.js:1529 tryCatch @ settings.js:604 invoke @ settings.js:830 prototype. @ settings.js:656 tryCatch @ settings.js:604 invoke @ settings.js:694 (anonymous) @ settings.js:706 Promise.then (async) invoke @ settings.js:703 (anonymous) @ settings.js:729 callInvokeWithMethodAndArg @ settings.js:728 enqueue @ settings.js:751 prototype. @ settings.js:656 exports.async @ settings.js:775 doLogin @ settings.js:1478 login @ settings.js:1542 onClick @ settings.js:1568 N @ settings.js:84

Thanks

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/johnjones4/Standard-Notes-Clipper/issues/28#issuecomment-736943102, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ2HQIMNVG5PSK4AJANKFNDSSWPVDANCNFSM4TZG2ZQA .

JonBallinger commented 3 years ago

I get this same issue, using server url of https://sync.standardnotes.org/ and my credentials that work for logging into standardnotes web.

diegocosmo commented 3 years ago

Same issue here.

johnjones4 commented 3 years ago

Sorry for the delay here! I believe this has been resolved in https://github.com/johnjones4/Standard-Notes-Clipper/releases/tag/1.7.1. Can someone please confirm for me?

JonBallinger commented 3 years ago

Hi John,

Thanks for looking into this. Unfortunately I still get the same error.

I removed the extension, closed Chrome, then reopened Chrome, and reloaded the extension from the new download.

Cheers,

Jonathan

On Mon, 21 Dec 2020 at 17:44, John E Jones IV notifications@github.com wrote:

Sorry for the delay here! I believe this has been resolved in https://github.com/johnjones4/Standard-Notes-Clipper/releases/tag/1.7.1. Can someone please confirm for me?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/johnjones4/Standard-Notes-Clipper/issues/28#issuecomment-749105911, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA7GQSLMNJLDRHDNULF5W3SV6CPHANCNFSM4TZG2ZQA .

randy9999 commented 3 years ago

I too have just tried it again. This time I downloaded a new standardnotes from the main website. I installed that on my mac and then downloaded and installed this new "fix" for the extension.

But...that did not work.

I am still getting the same error 'output is null'.

later Randy

On Mon, Dec 21, 2020 at 11:51 AM Jonathan Ballinger < notifications@github.com> wrote:

Hi John,

Thanks for looking into this. Unfortunately I still get the same error.

I removed the extension, closed Chrome, then reopened Chrome, and reloaded the extension from the new download.

Cheers,

Jonathan

On Mon, 21 Dec 2020 at 17:44, John E Jones IV notifications@github.com wrote:

Sorry for the delay here! I believe this has been resolved in https://github.com/johnjones4/Standard-Notes-Clipper/releases/tag/1.7.1. Can someone please confirm for me?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/johnjones4/Standard-Notes-Clipper/issues/28#issuecomment-749105911 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAA7GQSLMNJLDRHDNULF5W3SV6CPHANCNFSM4TZG2ZQA

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/johnjones4/Standard-Notes-Clipper/issues/28#issuecomment-749108887, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ2HQINQZENRAEIBFDSEJJDSV6DJJANCNFSM4TZG2ZQA .

sequent5 commented 3 years ago

I have just tried it with latest release 1.7.1, same error as last release 1.7.0 : Cannot read property 'length' of null.

johnjones4 commented 3 years ago

I tested this against a version of SN server running according to these instructions: https://docs.standardnotes.org/self-hosting/docker. Can you please add more details about your server installation so I can better test?

JonBallinger commented 3 years ago

I'm using it against the web version. Not self hosted.

On Tue, 22 Dec 2020 at 12:48, John E Jones IV notifications@github.com wrote:

I tested this against a version of SN server running according to these instructions: https://docs.standardnotes.org/self-hosting/docker. Can you please add more details about your server installation so I can better test?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/johnjones4/Standard-Notes-Clipper/issues/28#issuecomment-749523813, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA7GQQP4IGJZRRA2CNMV6TSWCISPANCNFSM4TZG2ZQA .

sequent5 commented 3 years ago

I tested this against two version( a self-hosting and a official web), same error while logging :Cannot read property 'length' of null. so I dont't think this error is related with standardnotes itself.

JaspalSuri commented 3 years ago

Hi @johnjones4,

I was unable to reproduce this issue for an account that is using v003 of SNJS, which would be what most accounts are using/on at the moment. I was able to view my tags in the legacy web app but not in the latest web app. You can create a test 003 account via the legacy web app.

However, for an account that is using v004 of SNJS, which would used by any account that was upgraded by a user changing their password via the desktop app after early November (of 2020) or by anyone who has made a new account since then, I was able to reproduce the issue and wasn't able to log in.

I also noticed that the extension doesn't appear to add tags that contain spaces or periods. Is this intentional? Periods help nest tags underneath each other and spaces are allowed in tag names.

Please let me know if you have any questions! Thanks for the updates so far and for maintaining this extension!

diegocosmo commented 3 years ago

The same issue remains for me as well. Version 1.7.1.

JonBallinger commented 3 years ago

This would fit with me, I created my account in November 2020 during the cyber week sale.

On Sun, 27 Dec 2020 at 10:36, Jaspal Suri notifications@github.com wrote:

Hi @johnjones4 https://github.com/johnjones4,

I was unable to reproduce this issue for an account that is using v003 of SNJS https://github.com/standardnotes/snjs/, which would be what most accounts are using/on at the moment. I was able to view my tags in the legacy web app http://app-legacy.standardnotes.org but not in the latest web app http://app.standardnotes.org. You can create a test 003 account via the legacy web app http://app-legacy.standardnotes.org.

However, for an account that is using v004 of SNJS, which would used by any account that was upgraded by a user changing their password via the desktop app after early November (of 2020) or by anyone who has made a new account since then, I was able to reproduce the issue and wasn't able to log in.

I also noticed that the extension doesn't appear to add tags that contain spaces or periods. Is this intentional? Periods help nest tags underneath each other and spaces are allowed in tag names.

Please let me know if you have any questions! Thanks for the updates so far and for maintaining this extension!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/johnjones4/Standard-Notes-Clipper/issues/28#issuecomment-751451186, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA7GQUF6G4TCGPFFN6QQZTSW4E2VANCNFSM4TZG2ZQA .

sequent5 commented 3 years ago

can log in using server url https://sync.standardnotes.org/ while letting E-mail/password empty.

JonBallinger commented 3 years ago

It gives the impression of logging in here as well when I use blank email/password, but none of my clips after having done so have surfaced in my notes anywhere.

On Tue, 29 Dec 2020 at 02:57, stjohn notifications@github.com wrote:

can log in using server url https://sync.standardnotes.org/ while letting E-mail/password empty.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/johnjones4/Standard-Notes-Clipper/issues/28#issuecomment-751928744, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA7GQWS22Q65EYVNNSXYPTSXFASPANCNFSM4TZG2ZQA .

Rustymage commented 3 years ago

I'm having this issue too.

Self hosted using SN instructions yesterday.

bscott commented 3 years ago

Update:

The Javascript library used in the SN Web Clipper is no longer supported by Standard Notes, That package is obsolete. The new package is SNJS. I am working on doing a refactor using the new SN JS library. We will need about a week or two to have this done then will need to test and create a new release.

randy9999 commented 3 years ago

Thank you! I am looking forward to maybe having a working Standard Notes.

On Mon, Jan 25, 2021 at 7:22 PM Brian Scott notifications@github.com wrote:

Update:

The Javascript library used in the SN Web Clipper is no longer supported by Standard Notes, That package is obsolete. The new package is SNJS. I am working on doing a refactor using the new SN JS library. We will need about a week or two to have this done then will need to test and create a new release.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/johnjones4/Standard-Notes-Clipper/issues/28#issuecomment-767218312, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ2HQIJACET3MFKC5F5CYCLS3YKL5ANCNFSM4TZG2ZQA .

bscott commented 3 years ago

A bit delayed with the updated Web Clipper but I plan on having a beta release soon.

randy9999 commented 3 years ago

Great, thanks for the update!

On Fri, Feb 26, 2021 at 8:28 PM Brian Scott notifications@github.com wrote:

A bit delayed with the updated Web Clipper but I plan on having a beta release soon.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/johnjones4/Standard-Notes-Clipper/issues/28#issuecomment-786988453, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ2HQINSAJWJHZTVYSQQEILTBBKGRANCNFSM4TZG2ZQA .