Cannot read property 'length' of null - Can't login

johnjones4 / Standard-Notes-Clipper

A browser add-on (Firefox and Chrome) that allows you to clip web pages to your Standard Notes account.

MIT License

124 stars 13 forks source link

Cannot read property 'length' of null - Can't login #30

Open bscott opened 3 years ago

bscott commented 3 years ago

After Trying to log in and asked for my 2FA code, I receive the following error:

Cannot read property 'length' of null

Using Edge browser

Console Log:

settings.js:1529 TypeError: Cannot read property 'length' of null
    at SFCryptoWeb._callee128$ (chrome-extension://fihpcbcgcjejccokoekllnnafdilelae/background/background.js:34284)
    at tryCatch (chrome-extension://fihpcbcgcjejccokoekllnnafdilelae/background/background.js:42247)
    at Generator.invoke [as _invoke] (chrome-extension://fihpcbcgcjejccokoekllnnafdilelae/background/background.js:42473)
    at Generator.prototype.<computed> [as next] (chrome-extension://fihpcbcgcjejccokoekllnnafdilelae/background/background.js:42299)
    at asyncGeneratorStep (chrome-extension://fihpcbcgcjejccokoekllnnafdilelae/background/background.js:23836)
    at _next (chrome-extension://fihpcbcgcjejccokoekllnnafdilelae/background/background.js:23838)

bscott commented 3 years ago

@johnjones4 if you want to add me as a Maintainer, I wouldn't mind working on some of the issues and accepting PR's

johnjones4 commented 3 years ago

Absolutely! Sorry I've been flaking on this. A few too many pots on the stove right now.

bscott commented 3 years ago

@johnjones4 Np!, Thanks for adding me and allowing me to help :)

ThePauler commented 3 years ago

Same issue on firefox and edge. Try to log in and I get Cannot read property 'length' of null

Hope it can get fixed. Would love to use this app for web clipping

anacoluthn commented 3 years ago

Having the same issue here on Chrome, hope it can get fixed soon!

bscott commented 3 years ago

@anacoluthn working on it, hoping to have a minor bug fix release this weekend

bscott commented 3 years ago

Update:

The Javascript library used in the SN Web Clipper is no longer supported by Standard Notes, That package is obsolete. The new package is SNJS. I am working on doing a refactor using the new SN JS library. We Will need about a week to have this done then will need to test and create a new release.

Librechain commented 3 years ago

Hey,

Just commenting so I can get an alert on this issue when the patch drops as I'm having the same issue as the users above.

Great job @bscott + @johnjones4 ; thanks a load for helping the community out. I'm grateful.

bscott commented 3 years ago

Thanks, working thru this week and testing with a few folks next week before releasing.

bscott commented 3 years ago

@johnjones4 Can you email me at bscott at hey.com, need to know your last release process, I have refactored using the new SNJS library.

johnjones4 commented 3 years ago

Thanks so much for your efforts here! I just emailed you

cherya commented 3 years ago

@bscott any updates on it? Maybe you need some help with testing or something?

bscott commented 3 years ago

I'm preparing a beta release for testing, resolving a few bugs first.

ThePauler commented 3 years ago

Any updates? Need beta testers?

bscott commented 3 years ago

@ThePauler Yes, a few minor issues I need to fix, looking for any contributors to speed up the release.