johnjones4 / Standard-Notes-Clipper

A browser add-on (Firefox and Chrome) that allows you to clip web pages to your Standard Notes account.
MIT License
124 stars 13 forks source link

Selecting prefered Editor in Settings not working #7

Closed jrabensc closed 4 years ago

jrabensc commented 4 years ago

The dropdown in the settings menu is currently empty and not working for me: image

johnjones4 commented 4 years ago

@jrabensc Which editors do you have installed in Standard Notes?

jrabensc commented 4 years ago

@johnjones4 These are my installed editors: image

johnjones4 commented 4 years ago

Really odd. Can grab a screenshot of the inspector for this plugin? (To get to that, go to Tools > Add-ons, then select the gear dropdown and click Debug Add-Ons, and then finally in the box for Standard Notes Clipper, click Inspect.)

jrabensc commented 4 years ago

Here's a screenshot of the inspector tab: image

I found some errors in the console tab and grabbed them too, maybe they are helpfull as well: image

joshcsullivan commented 4 years ago

Hi, I am using Brave (Chromium) and also having an issue with the preferred editor not loading. I am getting a JS error when it attempts to get the list of editors, I have Advanced Markdown Editor, Bold Editor, Code Editor, Minimal Markdown Editor, Plus Editor installed.

I've confirmed the extension has permissions to read and change site data on all sites.

Here is the console and error in the extension which shows it's encountering an error at the uuid:

Screen Shot 2019-11-02 at 6 54 48 AM
johnjones4 commented 4 years ago

@joshcsullivan @jrabensc thanks for all of this great detail. I just pushed a change that I think might address this. Can you update and test again for me? Thanks!

jrabensc commented 4 years ago

Its working: image

However, it is not possible to select the plain editor. Is there a reason for that?

johnjones4 commented 4 years ago

Good call! I've added Plain Editor as an option.

johnjones4 commented 4 years ago

@joshcsullivan looking good for you too?

joshcsullivan commented 4 years ago

Sorry, weekend was very busy.

Anyways, I can now select the Plain editor, but no other editors appear in the dropdown:

20191104-091425

As you can see, I have more editors than the Plain editor:

20191104-091345

johnjones4 commented 4 years ago

Looks like Brave/Chromium have different rules with the storage system. I've switched the add-on to use local storage which seems to fix the issue. You will need to log in again give the change in storage.

joshcsullivan commented 4 years ago

It's working now, thank you!