search

johnjung / bmrcportal

GNU General Public License v3.0
1 stars 1 forks source link

Genreform, Occupation should be clickable (Controlaccess/subject listings) #127

Closed MomoMoses closed 1 year ago

MomoMoses commented 2 years ago

Along with persname, corpname, geogname, and subject, genreform and occupation are frequently used as "subject" categories with which to find related materials. Ideally, these would be clickable and function the same way as the subject headings.

MomoMoses commented 2 years ago

is this a quick fix? if so, let's do it before launch if at all possible.

MomoMoses commented 2 years ago

priority #1 only if do-able fairly quickly. if not, then priority-2, which may bump it to phase 3.

johnjung commented 2 years ago

This is now fixed in https://github.com/uchicago-library/bmrc/commit/40e586b8f2ecef51db992592fdf487757bd6065a and live on bmrc-test.lib.

Genreform was missing, but all of the other elements that you mentioned should have already been clickable. Please let me know if this looks good or if I should keep debugging.

MomoMoses commented 2 years ago

Continuing with my perusal of DePaul records I came across this in this collection

African American student movements--Archival resources--Illinois--Chicago 
  <genreform source="ingest">University records</genreform>
  <corpname source="ingest">DePaul University--Students--Archives</corpname>
</controlaccess>`

Here, the genreform is not clickable. Is the attribute "source" somehow interfering? OK, wait, I'm checking the other test site now.

NEVER MIND! it's fixed in the other site...

MomoMoses commented 2 years ago

Looks good. If I come across anything not clickable it's probably a weird edge case. I can note it here and then determine further course of action.

MomoMoses commented 2 years ago

BMRC.CHM.AF-AM-POLICE-LEAGUE.xml has non-clickable genreform tags. Also: BMRC.CHM.ACLU-CHI-CHAP.xml Looking into the data.

johnjung commented 2 years ago

Please let me know if there is anything I can check on my end.

MomoMoses commented 1 year ago

With the most recent finding aid updates and other fixes, this now appears to be fine. As of February 2022 uploads and transformations.