johnjung / bmrcportal

GNU General Public License v3.0
1 stars 1 forks source link

container inventory: labels displaying on top of other text #156

Closed MomoMoses closed 2 years ago

MomoMoses commented 2 years ago

The attempted columnar display of the container list is not working in some cases. BMRC.DEPAUL.SMITH-CHARLES.xml Information on the left does not wrap and is overwriting the label "Box" with the number in the next "column."

johnjung commented 2 years ago

Because there are so many inventory container variations, all with different content widths, a simple way to change this is to make the text in the first column wrap when it's too long for its container. Here's an example that sets the overflow-wrap CSS property to "anywhere".

Current display:

without

With overflow-wrap: anywhere:

with

Please let me know if this works.

MomoMoses commented 2 years ago

This looks great!

On Fri, Apr 22, 2022, 10:59 AM John Jung @.***> wrote:

Because there are so many inventory container variations, all with different content widths, a simple way to change this is to make the text in the first column wrap when it's too long for its container. Here's an example that sets the overflow-wrap CSS property to "anywhere".

Current display: [image: without] https://user-images.githubusercontent.com/10198227/164751342-ffb9a218-a458-45aa-8c05-3156c6cdb30c.png

With overflow-wrap: anywhere: [image: with] https://user-images.githubusercontent.com/10198227/164751386-d61ac500-92c0-48cc-bbe7-6a70d5062078.png

Please let me know if this works.

— Reply to this email directly, view it on GitHub https://github.com/johnjung/bmrcportal/issues/156#issuecomment-1106651125, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA263WXLY3MUHZV7JZW2GS3VGLEEXANCNFSM5T75G2SQ . You are receiving this because you authored the thread.Message ID: @.***>

johnjung commented 2 years ago

This is now fixed in https://github.com/uchicago-library/bmrc/commit/993875ba9b04c20b1039c340ca04f4e11f7954cc and live on the server. Please take a look and let me know if this is ok.

MomoMoses commented 2 years ago

Oops, late confirmation. Yes, fixed.