search

johnjung / bmrcportal

GNU General Public License v3.0
1 stars 1 forks source link

Bad source data?: Section and subsections not properly nested #30

Closed MomoMoses closed 2 years ago

MomoMoses commented 2 years ago

Guide to the ACLU Illinois Division, UChicago, is the example. https://bmrcportal-test.lib.uchicago.edu/view/?id=BMRC.UOC.ACLU_IL.xml

The SECTION is called "INFORMATION ON USE" which has 8 subsections. Only the first two pertain to use: Access and Citation. Oddly, the actual use element in EAD Conditions Governing Use, does not appear at all here.

Not in the right hierarchical position: Processing Information note, Historical Note, Scope Note (which is actually a note on the Arrangement), Related Resources, Subject Headings, Terms added by the BMRC Team.

johnjung commented 2 years ago

This looks like a source data issue to me too. I'm going to tag these "data" so we can keep track of them.

MomoMoses commented 2 years ago

https://www.lib.uchicago.edu/e/scrc/findingaids/view.php?eadid=ICU.SPCL.ACLUIL Except that it might not be -- I looked for the collection on the UChicago SCRC site and it appears properly nested. I thought we used their EAD straight up, but I'll check. I like how the Series and Subseries appear here.

I checked and the EAD has very few, trivial differences (like number of spaces). Code is the same.

johnjung commented 2 years ago

Please check to see if there is an existing issue for series and subseries or create one, if necessary, so we can look at that separately. (Let's try to treat a single discrete problem per issue.)

I see that all of the other elements are nested under a <descgrp> element, where the <head> is "Information on Use", in both the UChicago XML and in the Portal XML. The UChicago finding aid viewer doesn't indent those nested elements in the left-hand sidebar, but the portal viewer sidebar does.

If you'd like to remove indentation from the table of contents we can do that, otherwise I recommend considering this a data issue. (i.e., to get elements to display at the same level as "Information on Use", move them out of the <descgrp> element.)

MomoMoses commented 2 years ago

Let's table this issue for now -- I don't think the source data should be changed.

Issue for later: remove indentation or not. #PhaseTwo