search

johnjung / bmrcportal

GNU General Public License v3.0
1 stars 1 forks source link

deprecated EAD elements in EAD3 #38

Closed MomoMoses closed 2 years ago

MomoMoses commented 2 years ago

We don't need to worry about these too much, as they weren't oft-used in any case: <extptr>, <extref>, <linkgrp>

If there is code addressing or styling/transforming these tags, unless needed, comment out code addressing the use and display of these tags. Especially if this code is causing any anomalies in display or other function.

johnjung commented 2 years ago

Is it possible to re-word this as an issue that can be fixed? If not, lets close this issue out.

johnjung commented 2 years ago

Right now, the transform tries to turn extptr and extref elements into HTML links, and it turns linkgrp elements into HTML unordered lists. Would you prefer that, if those elements appear in the EAD, nothing appears in the HTML? Or would you prefer that if those elements appear that plain text is output to HTML instead?

MomoMoses commented 2 years ago

If you grep the database as it exists right now, do these elements appear? I don't see them in the NAFAN dataset at all. If they don't appear, it does no harm, but no good either. Since it's done, though, I would leave it as you have it--those transforms are logical.

johnjung commented 2 years ago

Ok, that's great. There are currently no examples of extptr or linkgrp elements, however, there are extref elements- they appear in the following finding aids:

BMRC.HARSH.ABBOTT_SENGSTACKE.xml BMRC.HARSH.DURHAM.xml BMRC.HARSH.WYATT.xml BMRC.NU.TRANSP-LIB_MENUS.xml BMRC.UOC.ACLU_IL.xml BMRC.UOC.AFR-STUDIES_WKSHP.xml BMRC.UOC.AFRICANSTUDIES.xml BMRC.UOC.AFRICANWKSP.xml BMRC.UOC.AVC_CHI.xml BMRC.UOC.BURGESS.xml BMRC.UOC.BURGESSADDENDA.xml BMRC.UOC.CAHUSAC.xml BMRC.UOC.CIVDISARMCOMM.xml BMRC.UOC.SUNRA.xml

If you'd like to take a look to see how those elements render, please do. Otherwise we can close out this issue.

MomoMoses commented 2 years ago

I haven't found any that are rendering properly as clickable links. I had thought that was the aim...?

johnjung commented 2 years ago

The original issue here is now resolved, and yesterday's comment is a duplicate of https://github.com/johnjung/bmrcportal/issues/52. I'm going to close this issue out and finish resolving it over there.