search

johnjung / bmrcportal

GNU General Public License v3.0
1 stars 1 forks source link

Indexed Terms groups with subheads - able to display on TOC? #65

Closed MomoMoses closed 2 years ago

MomoMoses commented 2 years ago

To demonstrate the issue, go to good old https://bmrcportal-test.lib.uchicago.edu/view/?id=BMRC.UOC.ACLU_IL.xml. You will see on the LH sidebar two entries for "Indexed Terms". In the XML I see that there are two groups of terms -- one as assigned by the originating repository staff, and one as assigned by the BMRC Survey or CCPP team. I wanted to include both but not to intermix for the ease of repository staff later when updates are done.

Here is how the code is organized: The original headings using <persname>, <corpname>, and <subject>: `

Subject Headings 
    <persname>Baldwin, Roger N, (Roger Nash), 1884-1981 </persname>` etc. in a long list

and the additional headings by BMRC: `

Terms added by the BMRC Team: 
      <corpname rules="dacs" source="naf">American Jewish Congress.</corpname>`

This results in two entries in the TOC for "Indexed Terms". We could omit any additional groups of <controlaccess> lists from the TOC. OR we could include the headings as "Indexed Terms - [head]" which would result in: "Indexed Terms - Subject Headings Indexed Terms - Terms added by the BMRC Team:"

### Looking at this, I'm voting for simply using the first set of <controlaccess> terms and letting the user find the other sets below on their own.

johnjung commented 2 years ago

This is a continuation of https://github.com/johnjung/bmrcportal/issues/62- please try to re-open closed issues to continue working on them.

This finding aid illustrates a problem with changing <head> elements that finding aid authors have explicitly included. Here, I think the best solution is to only add headings where they don't already exist, and not to modify existing headings.

If you'd like, we can tag this as "phase-2" and tackle this later. I do think the phrasing used in finding aids could be improved, but I think it's out of scope for this phase of the project.

MomoMoses commented 2 years ago

This was a different issue -- it doesn't happen all that often however, so we can leave it if necessary. No need to address phrasing either, at this time, though you're right! That is something that might be needed in future.

The issue is grouping Indexed terms, each with their own heading, so that "Indexed Terms" shows up twice on the TOC. No need to change the <head> element. Can we select only the first <head> for the first <controlaccess> tag and leave off the others? JUST FOR THE TOC DISPLAY.

This allows us to leave the EAD as is, but not to clutter up the TOC.

johnjung commented 2 years ago

Let's leave this as-is and tag this as a possible future enhancement then. I think that this kind of processing can start to complicate the code, and at this point in the project I want to be sure that we hit our launch deadlines.