search

johnkary / phpunit-speedtrap

Reports on slow-running tests in your PHPUnit test suite
MIT License
783 stars 62 forks source link

Improve readability of results #47

Closed fain182 closed 2 years ago

fain182 commented 6 years ago

This PR should fix the #36 and improve readability with other subtle improvements:

screen shot 2018-07-13 at 16 17 26

localheinz commented 5 years ago

@fain182

What do you think about additionally rendering an empty line after the header and before the footer?

fain182 commented 5 years ago

What do you think about additionally rendering an empty line after the header and before the footer?

I think it's a good idea..

@johnkary what do you think about merging this?

johnkary commented 5 years ago

@fain182 Please see my comment pending review here about conditional color output: https://github.com/johnkary/phpunit-speedtrap/pull/47/files/#r202464176

  • show time in seconds instead of milliseconds

I am concerned this change would cause differences between the slow time display and the slowness threshold configuration. Display would be in seconds while slowness threshold in milliseconds. I do not think changing the configuration to seconds would make this library easier to use. What do you think about these concerns?

  • avoid dots at the start of the line to avoid confusion with the test results' report

I support this change. Could we also replace the trailing dots in the header with a colon:

You should really fix these slow tests (>500ms)...
   change to
You should really fix these slow tests (>500ms):