search

johnkary / phpunit-speedtrap

Reports on slow-running tests in your PHPUnit test suite
MIT License
783 stars 62 forks source link

Allow PHPUnit 8 #53

Closed Engerim closed 5 years ago

Engerim commented 5 years ago
johnkary commented 5 years ago

Hi @Engerim, Thank you for adding this support to the build matrix! Looks like things are working well against PHPUnit 8.

Could you please see my comment about having removed nightly from the build matrix?

Engerim commented 5 years ago

Hi @johnkary I don't see any comment about the nightly build, but I can add the nightly php again

johnkary commented 5 years ago

@Engerim Yes, could we please add - nightly back to PHP build matrix?

Engerim commented 5 years ago

Nightly is added again, but with allowed failures. php nightly is for now php 8.0.0-dev instead of 7.4.0-dev so i allow them to fail for now. See also this tweet and comments https://twitter.com/kelunik/status/1094228271942848518?s=21

Also interesting https://travis-ci.community/t/add-php-7-4-branch-to-test-against/2179

mazsudo commented 5 years ago

any plan to merge/release this @johnkary ? love this library and would be glad to keep using it with phpunit8 ;) could also help to preprare a next version as TestListener interface seems deprecated now with phpunit8 if you want ;)

Engerim commented 5 years ago

ping @johnkary everything works

johnkary commented 5 years ago

@Engerim Thank you for your help to allow PHPUnit 8 compatibility!