search

johnkary / phpunit-speedtrap

Reports on slow-running tests in your PHPUnit test suite
MIT License
782 stars 62 forks source link

fix(deprecation): move from deprecated listener to compatible hook system in PHPUnit 8 #67

Closed vlaurier closed 3 years ago

vlaurier commented 4 years ago

Closes https://github.com/johnkary/phpunit-speedtrap/issues/60

mremi commented 4 years ago

Hi @johnkary can you have a look please?

johnkary commented 4 years ago

@vlaurier I have published a new v3.2.0 that updates the Travis CI matrix. Could you merge master into this branch, resolve conflicts and push again to this PR?

This new implementation will be the basis for SpeedTrap v4.0!

vlaurier commented 4 years ago

@johnkary @mremi It should be good that way. Notice I also removed PHPUnit 7 support in composer.json as these changes are not BC.

vlaurier commented 4 years ago

@johnkary , are you OK with these changes then ?

thePanz commented 4 years ago

Any updates @johnkary ?

angelsk commented 4 years ago

Any ETA on this merge? Can I do anything to help test?

VaN-dev commented 3 years ago

I would need this to be merged too. @vlaurier could you resolve the 2 conflict files please ?

johnkary commented 3 years ago

Thank you, @vlaurier. I will have a look soon and merge toward a v4.0 release.

localheinz commented 3 years ago

@johnkary

Also, if you can, please take a look at the ✉️ that I sent you in regard to the new event system of phpunit/phpunit!

🤓

johnkary commented 3 years ago

@vlaurier Thank you again for your work implementing the Hooks system. I have built on top of your work and introduced PR #83 that completes the Hooks implementation. This will be a new major release version of SpeedTrap once merged.

Please follow progress of #83 for compatibility with PHPUnit 8.0+.