Exit code = 1 for `--csv skip-trivial-records` and CSV file's last record is blank

johnkerl / miller

Miller is like awk, sed, cut, join, and sort for name-indexed data such as CSV, TSV, and tabular JSON

https://miller.readthedocs.io

Other

8.93k stars 216 forks source link

Exit code = 1 for `--csv skip-trivial-records` and CSV file's last record is blank #1535

Open garyaderhold opened 6 months ago

garyaderhold commented 6 months ago

It makes sense to receive an exit code of 1 if the CSV contains a blank record and "skip-trivial-records" is not specified. But, if I specify "skip-trivial-records" and the file does indeed have trivial records shouldn't the exit code = 0?

That, or create another exit code that's for maybe warnings like this.

johnkerl commented 3 months ago

See also https://github.com/johnkerl/miller/issues/1572#issuecomment-2185309016 for complicating issues ...