search

johnkerl / miller

Miller is like awk, sed, cut, join, and sort for name-indexed data such as CSV, TSV, and tabular JSON
https://miller.readthedocs.io
Other
9.02k stars 217 forks source link

Compiling on newer go versions doesn't work #1655

Closed lespea closed 2 months ago

lespea commented 2 months ago

For whatever reason when compiling with go 1.23 it complains about needing to go tidy and running that bumps the go version to 1.21 and adds the toolchain directive, while also updating go.sum.

Compiling on go 1.20 works just fine without this update.

Not sure if you want to go all the way to 1.23 or do the minimum of 1.21 so I just picked the latter and can change if you want to.

johnkerl commented 2 months ago

@lespea let's keep 1.21.

Personally I'd love to go newer but for some of the various distro builds newer Go versions aren't always available

lespea commented 2 months ago

Hopefully this going from 1.19 -> 1.21 won't be too big of an issue. I don't know why it's complaining. I'm stuck w/1.20 @ work so I haven't used newer versions much.

johnkerl commented 2 months ago

Thank you @lespea ! :)