search

johnlawerance / xtrabackup

Puppet module to install, configure, and run backups using Percona Xtrabackup for mysql, percona-server, mariadb
https://forge.puppet.com/johnlawerance/xtrabackup
3 stars 7 forks source link

Release new version on puppet forge #13

Open tullis opened 4 years ago

tullis commented 4 years ago

Hi, Thanks for your work on this module. Is there a reason why you haven't released a new version on Puppet Forge for some time? I can put a reference to this repo in my Puppetfile but it would seem like a good idea to update the Forge, wouldn't it?

johnlawerance commented 4 years ago

Hey @tullis thanks for reaching out. Looks like there have been a few changes in master prepped for a 0.4.0 release with the following changes:

-  Add param for package-name #8
-  Update fingerprint for Debian/Ubuntu repo #7
-  Confirming support for Debian #3
-  Removed unneeded time output for shells script #9

I haven't done any testing on the module in some time on more recent versions of puppet. What version are you running it on? -- Would you perhaps be willing to vet the newer versions of puppet for issues #10 and #11 -- Thanks for opening #13 as well!

tullis commented 4 years ago

I'm running on Debian stretch, but I wanted to use the new package_name feature. I'm happy to help test other issues as well.

johnlawerance commented 4 years ago

That would be great if you could! Would be happy to cut a new release after :)

tullis commented 4 years ago

There is something amiss with the password handling, I believe. I'm using xtrabackup version 2.4.18

The MYSQL_PASS variable is correct at the top of /usr/local/bin/xtrabackup.sh (although this file is world readable) but when the script is run it doesn't put this variable in the right place in the command string.

Here is an extract from the log file:

xtrabackup: recognized client arguments: --port=3306 --socket=/var/run/mysqld/mysqld.sock --user=root --password=* --compress --backup=1 --user=root --password --target-dir=/var/backups/mysql/2020-03-10 
xtrabackup: Error: unknown argument: 'my_really_secret_password'