search

johnlemonse / homebridge-telldus

36 stars 22 forks source link

Added support for sensors and fixed get values for characteristics On and Brightness #11

Closed mansica closed 7 years ago

mansica commented 8 years ago

Temperature and humidity sensors, either combined or separate, are now added as accessories. Return values are now fixed for On and Brightness and a combination of those.

johnlemonse commented 8 years ago

Hi, I'll look at you changes during the weekend, in the meantime I have one question for you. What is this "Skalskydd" at line 186 and why is it located under "selflearning-dimmer" (line 185) with SecuritySystem as the service?

mansica commented 8 years ago

Hello, glad you find interest in my requests. I’m sorry about the ”skalskydd”. It is a local hack and should not be merged into your master. However, what it does is that it lets a fake dimmer accessory works as a security system if it is called ”Skalskydd”. Skalskydd means something like Perimeter security. I used a dimmer to be able to store the different states;

Characteristic.SecuritySystemCurrentState.STAY_ARM = 0; Characteristic.SecuritySystemCurrentState.AWAY_ARM = 1; Characteristic.SecuritySystemCurrentState.NIGHT_ARM = 2; Characteristic.SecuritySystemCurrentState.DISARMED = 3; Characteristic.SecuritySystemCurrentState.ALARM_TRIGGERED = 4; I’m fairly new to git and I didn’t think this code should be visible in the pull request. Sorry about that.

/Mats

10 mars 2016 kl. 01:15 skrev John Lemón notifications@github.com:

Hi, I'll look at you changes during the weekend, in the meantime I have one question for you. What is this "Skalskydd" at line 186 and why is it located under "selflearning-dimmer" (line 185) with SecuritySystem as the service?

— Reply to this email directly or view it on GitHub https://github.com/jchnlemon/homebridge-telldus/pull/11#issuecomment-194583421.

steam0 commented 7 years ago

@jchnlemon Do you mind merging in these changes? And can you open-source this project? Right now this is rotting on github, while users need to download a fork to make it work!