johnlemonse / homebridge-telldus

36 stars 22 forks source link

RESOLVED: ON/OFF Doesn't work #17

Closed KiqoCode closed 7 years ago

KiqoCode commented 8 years ago

Hi,

I use the homebridge-telldus plugin for homebridge, it does get my devices from telldus live but when I try to change the state of the device, nothing happends.

My config.json is as such:

{
    "bridge": {
        "name": "Homebridge",
        "username": "CC:22:3D:E3:CE:30",
        "port": 51826,
        "pin": "031-45-154"
    },

    "accessories": [
    ],

    "platforms": [
        {
            "platform" : "Telldus",
            "name" : "Telldus Liv!e",
            "public_key" : "secret",
            "private_key" : "secret",
            "token" : "secret",
            "token_secret" : "secret"
        }
    ]
}

When I use the "Eve" app on iOS (I have tried several but with the same result), in the terminal I get [9/13/2016, 4:01:14 PM] [Telldus Liv!e] [Giraff] Executing command bool : 1 and then nothing happens. In one app the 1 was changed to true but that didn't make a difference. And after that I get an error in the app saying HomeKit reported a communication failure. Please try again.

Anyone know a solution?

steam0 commented 8 years ago

THis is a duplicate of this issue

KiqoCode commented 8 years ago

Resolved. Removed index.js and replaced it with index.js and it works without any problems!

steam0 commented 8 years ago

What is the difference between these index.js-files? @cisco92

KiqoCode commented 8 years ago

They look totally different.. I just looked at a swedish Telldus forum and they all used with index.js instead of the original one.. Works with all devices it seems like. Just try it out.. Keep the original for backup.

steam0 commented 8 years ago

Maybe you should add a pull request for that index.js if this solves everyones problem?

KiqoCode commented 8 years ago

Yeah but I created my github account today.. So don't even know how to create a pull request.. xD

steam0 commented 8 years ago

Meh, nvm I just did it.

steam0 commented 8 years ago

Do you mind linking the webforum to me?

KiqoCode commented 8 years ago

https://github.com/mansica/homebridge-telldus

steam0 commented 8 years ago

Seems like he has already tried to add this as a pull request. Case closed and thank you.

KiqoCode commented 8 years ago

Did you try the replacement index.js to see if it worked??

steam0 commented 8 years ago

It worked like a charm. :)

ehenrik commented 8 years ago

I spent an evening applying these changes manually and can confirm that these changes work! Great job. It would however be awfully nice to get them packaged in a npm package since the fix has some dependencies etc. that have to be manually installed.

steam0 commented 8 years ago

We have tried. This dude just wont accept the pull request! 🙄

johnlemonse commented 8 years ago

Hi and sorry for the really late response, haven't had time to work on this at all for a couple of months... It will be changed from now on :)

I've merged the pull request now anyways. Please confirm if it works and I'll close this.

steam0 commented 8 years ago

Do you mind adding some of us as administrators to this project? I dont min answering questions and approving working pull requests.

I am the sole user in the homebridge-telldus channel on the official homebridge slack. Please do pop in if you want to.

steam0 commented 7 years ago

Verified by issue #16