search

johnlpage / POCDriver

Workload Driver for MongoDB in Java
Other
204 stars 87 forks source link

Upgrade Java driver #22

Closed jyemin closed 6 years ago

jyemin commented 6 years ago

What's the intention for the bin directory? Should new jar files be checked in on every commit?

I suggest deleting bin from the repository and requiring users to build themselves. If you want to make that simpler, switch to gradle, which is self-downloading.

johnlpage commented 6 years ago

I find in 90% of cases the end user cannot build it. The idea is to have a single jar they can download and run. So yes the jar at least needs to be in the repo.

On 25 Jan 2018 19:53, "Jeff Yemin" notifications@github.com wrote:

What's the intention for the bin directory? Should new jar files be checked in on every commit?

I suggest deleting bin from the repository and requiring users to build themselves. If you want to make that simpler, switch to gradle, which is self-downloading.

You can view, comment on, or merge this pull request online at:

https://github.com/johnlpage/POCDriver/pull/22 Commit Summary

  • Upgrade Java driver

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/johnlpage/POCDriver/pull/22, or mute the thread https://github.com/notifications/unsubscribe-auth/AEPhVilVd_4d92HMmW8XvGjg7kwbJ12Dks5tONuwgaJpZM4RtZZb .