Closed jyemin closed 6 years ago
I find in 90% of cases the end user cannot build it. The idea is to have a single jar they can download and run. So yes the jar at least needs to be in the repo.
On 25 Jan 2018 19:53, "Jeff Yemin" notifications@github.com wrote:
What's the intention for the bin directory? Should new jar files be checked in on every commit?
I suggest deleting bin from the repository and requiring users to build themselves. If you want to make that simpler, switch to gradle, which is self-downloading.
You can view, comment on, or merge this pull request online at:
https://github.com/johnlpage/POCDriver/pull/22 Commit Summary
- Upgrade Java driver
File Changes
- M bin/POCDriver.jar https://github.com/johnlpage/POCDriver/pull/22/files#diff-0 (0)
- M bin/original-POCDriver.jar https://github.com/johnlpage/POCDriver/pull/22/files#diff-1 (0)
- M pom.xml https://github.com/johnlpage/POCDriver/pull/22/files#diff-2 (4)
Patch Links:
- https://github.com/johnlpage/POCDriver/pull/22.patch
- https://github.com/johnlpage/POCDriver/pull/22.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/johnlpage/POCDriver/pull/22, or mute the thread https://github.com/notifications/unsubscribe-auth/AEPhVilVd_4d92HMmW8XvGjg7kwbJ12Dks5tONuwgaJpZM4RtZZb .
What's the intention for the bin directory? Should new jar files be checked in on every commit?
I suggest deleting bin from the repository and requiring users to build themselves. If you want to make that simpler, switch to gradle, which is self-downloading.