search

johnlpage / POCDriver

Workload Driver for MongoDB in Java
Other
204 stars 87 forks source link

JAR file should be created in default `target` folder rather than `bin` #28

Closed niccottrell closed 6 years ago

niccottrell commented 6 years ago

I believe Maven normally creates packages in target and in fact there is a file there but it is missing the 'main' class. I propose we use Maven default output path for the JAR and remove bin folder completely. Thoughts?

swsms commented 6 years ago

Hello, I just removed outputDirectory from the configuration section of the maven-shade-plugin (pom.xml).

After packaging, I can successfully start it

java -jar target/POCDriver.jar

I do not have a problem with the 'main' class. What is the problem?

niccottrell commented 6 years ago

Fixed in https://github.com/johnlpage/POCDriver/commit/c5203b6ad8e428d6a3a1bb1c132f83799434324f

johnlpage commented 6 years ago

It wasn't accidental that the final build stage moves it to bin. This caters for the majority of users who don't compile it and want to download a ready to run binary. Do this by all means but then manually copy to bin and upload to GitHub for those who just want to download the prebuilt jar.

On Wed, 27 Jun 2018, 15:42 Nicholas Cottrell, notifications@github.com wrote:

Fixed in c5203b6 https://github.com/johnlpage/POCDriver/commit/c5203b6ad8e428d6a3a1bb1c132f83799434324f

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/johnlpage/POCDriver/issues/28#issuecomment-400805336, or mute the thread https://github.com/notifications/unsubscribe-auth/AEPhViA9eFQzNpwY2u-MWHVnsy0A3NE3ks5uA-ApgaJpZM4Uuyjh .

johnlpage commented 6 years ago

Also you have now broken some customers build process.

On Wed, 27 Jun 2018, 15:42 Nicholas Cottrell, notifications@github.com wrote:

Fixed in c5203b6 https://github.com/johnlpage/POCDriver/commit/c5203b6ad8e428d6a3a1bb1c132f83799434324f

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/johnlpage/POCDriver/issues/28#issuecomment-400805336, or mute the thread https://github.com/notifications/unsubscribe-auth/AEPhViA9eFQzNpwY2u-MWHVnsy0A3NE3ks5uA-ApgaJpZM4Uuyjh .

niccottrell commented 6 years ago

Ok, I made the issue since I found a customer getting confused with copies of the jar in package/ and bin/. Should I just revert then?

johnlpage commented 6 years ago

I would. The bin directory predates the use of maven in the project.

On Wed, 27 Jun 2018, 16:00 Nicholas Cottrell, notifications@github.com wrote:

Ok, I made the issue since I found a customer getting confused with copies of the jar in package/ and bin/. Should I just revert then?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/johnlpage/POCDriver/issues/28#issuecomment-400810163, or mute the thread https://github.com/notifications/unsubscribe-auth/AEPhVgIfRCRTBmn6Bey3hkNQL7Ova49Qks5uA-RCgaJpZM4Uuyjh .

niccottrell commented 6 years ago

Reverted, but what is the purpose of original-POCDriver.jar? It's not documented anywhere.

johnlpage commented 6 years ago

If you can figure how to ditch that please do so

On Wed, 27 Jun 2018, 17:00 Nicholas Cottrell, notifications@github.com wrote:

Reverted, but what is the purpose of original-POCDriver.jar? It's not documented anywhere.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/johnlpage/POCDriver/issues/28#issuecomment-400827486, or mute the thread https://github.com/notifications/unsubscribe-auth/AEPhVp9ZksmSAdMR4bjmJzRet3jpa5Auks5uA_J5gaJpZM4Uuyjh .

niccottrell commented 6 years ago

It's just a temporary jar built by maven before the shading stage. We can just remove it from source control