Closed tjworks closed 5 years ago
Ok, that's cool
On Tue, 18 Dec 2018, 05:12 TJ <notifications@github.com wrote:
This allows the tool to track the latency performance at different latency threshold. For instance, one may be interested to see how many were under 10ms, how many were under 50ms, how many were under 100ms etc.
You can view, comment on, or merge this pull request online at:
https://github.com/johnlpage/POCDriver/pull/32 Commit Summary
- support multiple latency
- remove debug line
- remove unused lines
- fix typo bug
File Changes
- M src/main/java/com/johnlpage/pocdriver/MongoWorker.java https://github.com/johnlpage/POCDriver/pull/32/files#diff-0 (32)
- M src/main/java/com/johnlpage/pocdriver/POCDriver.java https://github.com/johnlpage/POCDriver/pull/32/files#diff-1 (4)
- M src/main/java/com/johnlpage/pocdriver/POCTestOptions.java https://github.com/johnlpage/POCDriver/pull/32/files#diff-2 (16)
- M src/main/java/com/johnlpage/pocdriver/POCTestReporter.java https://github.com/johnlpage/POCDriver/pull/32/files#diff-3 (33)
- M src/main/java/com/johnlpage/pocdriver/POCTestResults.java https://github.com/johnlpage/POCDriver/pull/32/files#diff-4 (25)
- M src/main/java/com/johnlpage/pocdriver/POCopStats.java https://github.com/johnlpage/POCDriver/pull/32/files#diff-5 (5)
Patch Links:
- https://github.com/johnlpage/POCDriver/pull/32.patch
- https://github.com/johnlpage/POCDriver/pull/32.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/johnlpage/POCDriver/pull/32, or mute the thread https://github.com/notifications/unsubscribe-auth/AEPhVt5iKIvgOmUUAQD6i_AHLauMtJEzks5u6HlNgaJpZM4ZXnL6 .
Didn't notice your comments in my previously closed PR before I submitted this new one. My implementation only added a few more counters so I believe it may not add much memory overhead.
OK, that works
On Tue, 18 Dec 2018, 06:39 TJ <notifications@github.com wrote:
Didn't notice your comments in my previously closed PR before I submitted this new one. My implementation only added a few more counters so I believe it may not add much memory overhead.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/johnlpage/POCDriver/pull/32#issuecomment-448113477, or mute the thread https://github.com/notifications/unsubscribe-auth/AEPhVpqSI6Y0LBNZuqHEFYSWBDBbbTnmks5u6I2wgaJpZM4ZXnL6 .
Merged but had to fix a but in CSV output with -o missing a comma
This allows the tool to track the latency performance at different latency threshold. For instance, one may be interested to see how many were under 10ms, how many were under 50ms, how many were under 100ms etc.