johnlpage / POCDriver

Workload Driver for MongoDB in Java
Other
204 stars 87 forks source link

Support multiple latency threshold values #32

Closed tjworks closed 5 years ago

tjworks commented 5 years ago

This allows the tool to track the latency performance at different latency threshold. For instance, one may be interested to see how many were under 10ms, how many were under 50ms, how many were under 100ms etc.

johnlpage commented 5 years ago

Ok, that's cool

On Tue, 18 Dec 2018, 05:12 TJ <notifications@github.com wrote:

This allows the tool to track the latency performance at different latency threshold. For instance, one may be interested to see how many were under 10ms, how many were under 50ms, how many were under 100ms etc.

You can view, comment on, or merge this pull request online at:

https://github.com/johnlpage/POCDriver/pull/32 Commit Summary

  • support multiple latency
  • remove debug line
  • remove unused lines
  • fix typo bug

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/johnlpage/POCDriver/pull/32, or mute the thread https://github.com/notifications/unsubscribe-auth/AEPhVt5iKIvgOmUUAQD6i_AHLauMtJEzks5u6HlNgaJpZM4ZXnL6 .

tjworks commented 5 years ago

Didn't notice your comments in my previously closed PR before I submitted this new one. My implementation only added a few more counters so I believe it may not add much memory overhead.

johnlpage commented 5 years ago

OK, that works

On Tue, 18 Dec 2018, 06:39 TJ <notifications@github.com wrote:

Didn't notice your comments in my previously closed PR before I submitted this new one. My implementation only added a few more counters so I believe it may not add much memory overhead.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/johnlpage/POCDriver/pull/32#issuecomment-448113477, or mute the thread https://github.com/notifications/unsubscribe-auth/AEPhVpqSI6Y0LBNZuqHEFYSWBDBbbTnmks5u6I2wgaJpZM4ZXnL6 .

johnlpage commented 5 years ago

Merged but had to fix a but in CSV output with -o missing a comma