johnma2006 / mamba-minimal

Simple, minimal implementation of the Mamba SSM in one file of PyTorch.
Apache License 2.0
2.62k stars 191 forks source link

about causal conv #22

Open HHHKKKHHH opened 8 months ago

HHHKKKHHH commented 8 months ago

I note that the convolution used in the original paper is causal convolution, but I don't seem to see an implementation of causal convolution in this project. A common grouping convolution is used in model.py. I wonder if this is correct

johnma2006 commented 7 months ago

That part is here: https://github.com/johnma2006/mamba-minimal/blob/master/model.py#L185 For reference: https://github.com/Dao-AILab/causal-conv1d