search

johnmaguire / Cardinal

A Python IRC bot, designed to make adding functionality quick and simple. (est. 2013)
MIT License
100 stars 38 forks source link

Feature/movie #137

Closed target111 closed 4 years ago

target111 commented 6 years ago

Implement movie plugin. The plugin returns information about a movie using the omdb api.

johnmaguire commented 6 years ago

Finally getting around to reviewing this... I squashed your commits, and fixed some lint errors on this branch: https://github.com/JohnMaguire/Cardinal/tree/feature/movie-plugin

Just applied for an OMDb API key but it's taking a while to receive, so it'll have to wait for now.

target111 commented 6 years ago

I can send you my api key if you still haven't got yours. Also if you're interested you can join us over at irc.anonops.com:6697 #cardinal to test some of the other plugins from my pull requests. (if you join and I'm not online know that the bot responds to '=' )

johnmaguire commented 4 years ago

Again, sorry for letting this languish for 2 years! I'm not sure I want to run with OMDb. I may investigate something with Rotten Tomatoes or similar. Thank you so much for this contribution though!

johnmaguire commented 3 years ago

Hey, I did end up merging this actually in 021d447851e0c7ecf0ab2326fb83e8812bb0a6aa. Thanks a bunch for the PR!