search

johnmaguire / Cardinal

A Python IRC bot, designed to make adding functionality quick and simple. (est. 2013)
MIT License
100 stars 38 forks source link

Add music icons next to YT music video titles #190

Closed dkim286 closed 3 years ago

dkim286 commented 3 years ago

Resolves this issue: https://github.com/JohnMaguire/Cardinal/issues/179

dkim286 commented 3 years ago

I forgot to add, the value (10) is based on the result of the query made to YouTube API on June 4th 2021:

>>> for kind in y.json()['items']:
...     print(kind['id'], kind['snippet']['title'])
... 
1 Film & Animation
2 Autos & Vehicles
10 Music
15 Pets & Animals
17 Sports
18 Short Movies
19 Travel & Events
20 Gaming
21 Videoblogging
22 People & Blogs
23 Comedy
24 Entertainment
25 News & Politics
26 Howto & Style
27 Education
28 Science & Technology
29 Nonprofits & Activism
30 Movies
31 Anime/Animation
32 Action/Adventure
33 Classics
34 Comedy
35 Documentary
36 Drama
37 Family
38 Foreign
39 Horror
40 Sci-Fi/Fantasy
41 Thriller
42 Shorts
43 Shows
44 Trailers
>>>
johnmaguire commented 3 years ago

@dkim286 This looks great! I'll test it out locally soon and then merge it in. Thank you for the PR!

johnmaguire commented 3 years ago

Worked great, thanks again!

johnmaguire commented 3 years ago

Oh, by the way, it's totally optional, but feel free to submit another PR updating the CONTRIBUTORS file with your name!

dkim286 commented 3 years ago

thank you. i''ll do so once i've cleared some coursework backlog.