search

johnmahlon / Coffee-Ratio

This is an open source app made to help home brewers brew their coffee by calculating the grams of water needed, and run a timer all in the same screen.
87 stars 54 forks source link

Keyboard pushes CoffeeInput out of frame #17

Closed NateFuller closed 2 years ago

NateFuller commented 3 years ago

Hey @johnmahlon - Trying to get my feet wet with SwiftUI and this is the perfect starter for me. Found this little visual bug with the keyboard on an iPhone 12 Pro Max simulator running iOS 14.5

simulator_screenshot_EEDBACB5-502C-4369-8C4C-78891DDEDA52

I'm very familiar with building apps with Interface Builder but am brand new to SwiftUI. I'm going to tinker around and see if I can fix this issue. If you have any tips in the meantime, feel free to lmk here.

Edit: Realizing that the screenshot doesn't show the notch of the simulator. But the notch is blocking the view, so I'm guessing it's just a matter of telling the VStack to obey the safe area or something along those lines.

Ravneet5911 commented 2 years ago

I would like to work on this issue, May I?

johnmahlon commented 2 years ago

@Ravneet6041 sure!

Ravneet5911 commented 2 years ago

assign me plz

Ravneet5911 commented 2 years ago

Hey @johnmahlon
I have done with this issue and created a pull request for master. Kindly have a look on it and let me know if I miss something. Thanks