search

johnmartins / mdac

multi-disciplinary analysis client
https://mdac.netlify.app/
MIT License
4 stars 1 forks source link

Inter-similarity analysis does not return 0 #80

Closed johnmartins closed 1 year ago

johnmartins commented 1 year ago

Bug in code:

// Store nearest similarity value
if (!closestSimilarityValue {
    closestSimilarityValue = s
} else if (closestSimilarityValue > s) {
    closestSimilarityValue = s
}

Proposed solution:

// Store nearest similarity value
if (!closestSimilarityValue && closestSimilarityValue !== 0) {
    closestSimilarityValue = s
} else if (closestSimilarityValue > s) {
    closestSimilarityValue = s
}
johnmartins commented 1 year ago

Fixed a long time ago