johnmchambers / XRJulia

XR-style Interface to Julia (from "Extending R")
33 stars 2 forks source link

Doesn't seem to work with Julia v1.0 #22

Open olugovoy opened 5 years ago

olugovoy commented 5 years ago

Hello, I assume the package is not adjusted yet to the new Julia release? Tried on Mac: `> library(XRJulia)

findJulia() [1] "/usr/local/bin/julia" findJulia(test = TRUE) ERROR: MethodError: no method matching parse(::String) Closest candidates are: parse(!Matched::Type{T<:Integer}, !Matched::AbstractChar; base) where T<:Integer at parse.jl:38 parse(!Matched::Type{LibGit2.GitCredential}, !Matched::AbstractString) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/LibGit2/src/gitcredential.jl:71 parse(!Matched::Type{LibGit2.GitCredentialHelper}, !Matched::AbstractString) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/LibGit2/src/gitcredential.jl:158 ... Stacktrace: [1] top-level scope at none:0 ERROR: UndefVarError: STDOUT not defined Stacktrace: [1] top-level scope at none:8 [1] FALSE` It worked with 0.6 version.

johnmchambers commented 5 years ago

Correct. The package was tested vs Julia 0.6. The plan is to update it. Any suggested changes would be appreciated.

On Dec 6, 2018, at 5:41 PM, olugovoy notifications@github.com<mailto:notifications@github.com> wrote:

Hello, I assume the package is not adjusted yet to the new Julia release? Tried on Mac: `> library(XRJulia)

findJulia() [1] "/usr/local/bin/julia" findJulia(test = TRUE) ERROR: MethodError: no method matching parse(::String) Closest candidates are: parse(!Matched::Type{T<:Integer}, !Matched::AbstractChar; base) where T<:Integer at parse.jl:38 parse(!Matched::Type{LibGit2.GitCredential}, !Matched::AbstractString) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/LibGit2/src/gitcredential.jl:71 parse(!Matched::Type{LibGit2.GitCredentialHelper}, !Matched::AbstractString) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/LibGit2/src/gitcredential.jl:158 ... Stacktrace: [1] top-level scope at none:0 ERROR: UndefVarError: STDOUT not defined Stacktrace: [1] top-level scope at none:8 [1] FALSE` It worked with 0.6 version.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/johnmchambers/XRJulia/issues/22, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABPfyk3KGRS_ewSnOux5TIdwG3xqHRgKks5u2cdIgaJpZM4ZHonW.

oliviaAB commented 5 years ago

Hi,

Here are two suggestions of change for the new Julia syntax:

I hope this helps.

Thanks!

johnmchambers commented 5 years ago

Thanks for the catch on fieldnames(). Should be fixed as of commit today.

The convert() warning doesn't seem to come from XRJulia. No use of this Julia type in the code. This would need a self-contained code example that generates it to look further.

The file tests/require_v0.7.R has a collection of R source that has generated Julia warnings/errors previously but now should go through smoothly.

A frustration with Julia is that AFIK there is no way to force all lines of a source file to be compiled w/o knowing how to trigger all versions of all functions.